Support whitespace in function decls#5
Conversation
ST-DDT
left a comment
There was a problem hiding this comment.
I'm not sire whether capturing groups are nessesary but this looks like a nice addition.
Maybe we could add some testcases somewhere to the project to verify the entire code still works (in future updates).
|
That would be a good idea. Using this at Pearson for our internal TechOps shell scripts, might have a look at adding in tests while I'm adding in tests to our stuff as well. My guess would be that your preference is to use tests.sh? |
|
As for the capture groups, I'm used to building lexers so they are automatic in my brain for whitespace. Probably not necessary. |
|
@jdarling: Maybe use I guess, with |
|
@jdarling: Can you take a look at my comment so I can merge your PR? |
|
Sorry I completely missed your comment. Switched over and seems to work just fine with all the cases I have in our docs. Unfortunately this also brings in a change to allow @name usage (needs readme update) for the case where we are wanting to document a unit instead of a function. |
|
Solved in #8. |
Addresses #4
The current pattern doesn't allow for whitespace in function decls, this adds some basic support.