agent: @U0AJM7X8FBR Admin - I want a page to view the recent task runs for a sp#10
Merged
sweetmantech merged 4 commits intomainfrom Mar 16, 2026
Conversation
- /accounts/[account_id]: new page showing task runs per account - AccountDetailPage: shows Pulse runs filtered from all runs, with a collapsible "all runs" section - TaskRunsTable: table with status badges, duration, and run IDs - AccountReposList: now shows clickable account email → /accounts/[id] with repo URL as secondary link - sandboxesColumns: account email is now a clickable link to /accounts/[id] - fetchAccountTaskRuns + useAccountTaskRuns: data layer for the page Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughA new account detail page feature displays task runs for specific accounts. The implementation includes a dynamic Next.js page route, React components for account details and task run tables, a custom hook with auto-refetch capability using React Query and Privy authentication, API integration for fetching task runs, enriched type definitions, and refactored components to support account navigation. Changes
Sequence DiagramsequenceDiagram
participant Client as Client/Browser
participant Page as Next.js Page<br/>(app/accounts/[account_id])
participant AccountDetail as AccountDetailPage<br/>Component
participant Hook as useAccountTaskRuns<br/>Hook
participant Auth as Privy Auth<br/>Service
participant API as Backend API<br/>(/api/tasks/runs)
Client->>Page: Navigate to /accounts/{account_id}
Page->>Page: Resolve params.account_id
Page->>AccountDetail: Render with accountId
AccountDetail->>Hook: useAccountTaskRuns(accountId)
Hook->>Auth: Check if ready & authenticated
Auth-->>Hook: Ready & authenticated status
Hook->>Auth: getAccessToken()
Auth-->>Hook: Access token
Hook->>API: GET /api/tasks/runs?account_id=X&limit=20<br/>(Authorization: Bearer token)
API-->>Hook: TaskRun[] | error
Hook-->>AccountDetail: {data, isLoading, error}
AccountDetail->>AccountDetail: Filter pulseRuns<br/>(taskIdentifier === "send-pulse-task")
AccountDetail->>AccountDetail: Render breadcrumbs,<br/>pulse stats, TaskRunsTable
AccountDetail-->>Client: Display account detail view
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
lib/recoup/fetchAccountTaskRuns.ts (1)
22-24: Consider adding a request timeout for resilience.The fetch call has no timeout, which could cause the request to hang indefinitely if the server is unresponsive. This is a minor resilience concern.
🛡️ Optional: Add AbortController timeout
export async function fetchAccountTaskRuns( accessToken: string, accountId: string, limit = 20, ): Promise<TaskRun[]> { const url = new URL(`${API_BASE_URL}/api/tasks/runs`); url.searchParams.set("account_id", accountId); url.searchParams.set("limit", String(limit)); + const controller = new AbortController(); + const timeoutId = setTimeout(() => controller.abort(), 30_000); + - const res = await fetch(url.toString(), { - headers: { Authorization: `Bearer ${accessToken}` }, - }); + try { + const res = await fetch(url.toString(), { + headers: { Authorization: `Bearer ${accessToken}` }, + signal: controller.signal, + }); + clearTimeout(timeoutId);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/recoup/fetchAccountTaskRuns.ts` around lines 22 - 24, Add a timeout using AbortController around the fetch in fetchAccountTaskRuns: create an AbortController, start a setTimeout that calls controller.abort() after a chosen timeout (e.g., 10s), pass controller.signal to fetch(url.toString(), { headers: { Authorization: `Bearer ${accessToken}` }, signal }), and clear the timeout after fetch completes to avoid leaks; handle AbortError/timeout appropriately where res is used.components/AccountDetail/AccountDetailPage.tsx (1)
82-93: Consider whether "All task runs" should exclude pulse runs already shown.The collapsible section displays all runs including the pulse runs already shown above. This may be intentional for a complete view, but could cause confusion. If you want to avoid redundancy, filter out pulse runs:
💡 Optional: Show only non-pulse runs in collapsible section
{!isLoading && !error && runs && runs.length > pulseRuns.length && ( <details className="mt-6"> <summary className="cursor-pointer text-sm font-medium text-gray-600 dark:text-gray-300 hover:text-gray-900 dark:hover:text-gray-100"> - All task runs ({runs.length}) + Other task runs ({runs.length - pulseRuns.length}) </summary> <div className="mt-3"> - <TaskRunsTable runs={runs} /> + <TaskRunsTable runs={runs.filter(r => r.taskIdentifier !== "send-pulse-task")} /> </div> </details> )}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/AccountDetail/AccountDetailPage.tsx` around lines 82 - 93, The collapsible "All task runs" currently renders the full runs list including pulseRuns, causing duplication; update AccountDetailPage to compute a nonPulseRuns array (e.g., filter runs by excluding IDs present in pulseRuns) and use that for the collapsible section's header count and TaskRunsTable render, and adjust the visibility condition to check nonPulseRuns.length instead of comparing runs.length to pulseRuns.length; reference symbols: isLoading, error, pulseRuns, runs, nonPulseRuns (new), TaskRunsTable, AccountDetailPage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@types/sandbox.ts`:
- Line 26: Import the AccountRepo type into
components/SandboxOrgs/sandboxOrgsColumns.tsx and update the sorting/value
extraction to use the correct type: replace getValue<string[]>("account_repos")
with getValue<AccountRepo[]>("account_repos") (or otherwise annotate the column
accessor as AccountRepo[]), and ensure any downstream code that assumes strings
handles AccountRepo objects (e.g., accessing repo name via the appropriate
property). This touches the column definition / sorting function that references
account_repos and the file-level imports—add AccountRepo to the import list and
update the type parameter in the sorting/getValue call.
---
Nitpick comments:
In `@components/AccountDetail/AccountDetailPage.tsx`:
- Around line 82-93: The collapsible "All task runs" currently renders the full
runs list including pulseRuns, causing duplication; update AccountDetailPage to
compute a nonPulseRuns array (e.g., filter runs by excluding IDs present in
pulseRuns) and use that for the collapsible section's header count and
TaskRunsTable render, and adjust the visibility condition to check
nonPulseRuns.length instead of comparing runs.length to pulseRuns.length;
reference symbols: isLoading, error, pulseRuns, runs, nonPulseRuns (new),
TaskRunsTable, AccountDetailPage.
In `@lib/recoup/fetchAccountTaskRuns.ts`:
- Around line 22-24: Add a timeout using AbortController around the fetch in
fetchAccountTaskRuns: create an AbortController, start a setTimeout that calls
controller.abort() after a chosen timeout (e.g., 10s), pass controller.signal to
fetch(url.toString(), { headers: { Authorization: `Bearer ${accessToken}` },
signal }), and clear the timeout after fetch completes to avoid leaks; handle
AbortError/timeout appropriately where res is used.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 711b8ad5-dc7e-42a4-9705-0a693c2d97e9
📒 Files selected for processing (8)
app/accounts/[account_id]/page.tsxcomponents/AccountDetail/AccountDetailPage.tsxcomponents/AccountDetail/TaskRunsTable.tsxcomponents/SandboxOrgs/AccountReposList.tsxcomponents/Sandboxes/sandboxesColumns.tsxhooks/useAccountTaskRuns.tslib/recoup/fetchAccountTaskRuns.tstypes/sandbox.ts
| earliest_committed_at: string; | ||
| latest_committed_at: string; | ||
| account_repos: string[]; | ||
| account_repos: AccountRepo[]; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the stale type assertion in sandboxOrgsColumns.tsx
rg -n "getValue<string\[\]>.*account_repos" --type tsRepository: recoupable/admin
Length of output: 303
🏁 Script executed:
# Check the type definition in types/sandbox.ts around line 26
sed -n '20,30p' types/sandbox.tsRepository: recoupable/admin
Length of output: 335
🏁 Script executed:
# Check the imports in sandboxOrgsColumns.tsx to see if AccountRepo is imported
head -30 components/SandboxOrgs/sandboxOrgsColumns.tsx | grep -E "import|from"Repository: recoupable/admin
Length of output: 378
🏁 Script executed:
# Search for any other getValue calls with account_repos to ensure we catch all instances
rg -n "getValue.*account_repos" components/SandboxOrgs/sandboxOrgsColumns.tsxRepository: recoupable/admin
Length of output: 285
Add AccountRepo import and update type annotations in sorting function.
The account_repos field changed from string[] to AccountRepo[] in types/sandbox.ts. The sorting function in components/SandboxOrgs/sandboxOrgsColumns.tsx (lines 50-51) still uses the incorrect getValue<string[]>("account_repos") type. Additionally, AccountRepo is not imported in this file.
Update the import statement and the sorting function:
Required changes in sandboxOrgsColumns.tsx
-import type { OrgRepoRow } from "@/types/sandbox";
+import type { OrgRepoRow, AccountRepo } from "@/types/sandbox"; sortingFn: (rowA, rowB) => {
- const a = (rowA.getValue<string[]>("account_repos") ?? []).length;
- const b = (rowB.getValue<string[]>("account_repos") ?? []).length;
+ const a = (rowA.getValue<AccountRepo[]>("account_repos") ?? []).length;
+ const b = (rowB.getValue<AccountRepo[]>("account_repos") ?? []).length;
return a - b;
},🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@types/sandbox.ts` at line 26, Import the AccountRepo type into
components/SandboxOrgs/sandboxOrgsColumns.tsx and update the sorting/value
extraction to use the correct type: replace getValue<string[]>("account_repos")
with getValue<AccountRepo[]>("account_repos") (or otherwise annotate the column
accessor as AccountRepo[]), and ensure any downstream code that assumes strings
handles AccountRepo objects (e.g., accessing repo name via the appropriate
property). This touches the column definition / sorting function that references
account_repos and the file-level imports—add AccountRepo to the import list and
update the type parameter in the sorting/getValue call.
SRP: move getStatusBadgeColor and formatRunDuration to lib/tasks/ so TaskRunsTable only handles rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SRP: move breadcrumb rendering out of AccountDetailPage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sweetmantech
commented
Mar 16, 2026
Comment on lines
+44
to
+48
| {isLoading && ( | ||
| <div className="py-12 text-center text-sm text-gray-500 dark:text-gray-400"> | ||
| Loading task runs… | ||
| </div> | ||
| )} |
Contributor
Author
There was a problem hiding this comment.
DRY / SRP
- actual: defining loading text in Page component
- required: use existing skeleton components instead of loading text
| if (runs.length === 0) { | ||
| return ( | ||
| <p className="text-sm text-gray-500 dark:text-gray-400 py-8 text-center"> | ||
| No task runs found for this account. |
Contributor
Author
There was a problem hiding this comment.
False positive
- actual: on initial page land, I see this error message instead of the loading skeleton.
- required: on initial page load, I see the skeleton. This message should only appear if the query has run.
| title={repo_url} | ||
| > | ||
| {name} | ||
| {repoName} |
Contributor
Author
There was a problem hiding this comment.
remove repo name. we only want to see the emails.
1. Use existing TableSkeleton instead of loading text 2. Return null for empty runs to prevent false positive on initial load 3. Remove repo name from AccountReposList, only show emails Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR from coding agent.
Prompt: @U0AJM7X8FBR Admin - I want a page to view the recent task runs for a specific account. More specifically, I want to see the Pulse tasks which are run for a specific account.Most important question: What Pulse emails has Alexis received in the past 7 days?Recommended implementationTasks - pulse - Have the existing bulk Pulse task spawn a new, pulse , sub-task which executes for one account AND tags the account for easy querying. The results of the pulse sub task should include the roomId so we can query emails associated with the room.Docs - GET /api/tasks/runs - Update the existing API Docs to allow an account_id param (optional) which is only applicable for org api keys. Use this param for getting all runs associated with a specific account which is different from the account authenticated via API keys. Follows documentation-driven development.API - GET /api/tasks/runs - Update the existing API endpoint following the Docs changes to add the account_id param. Follows documentation-driven development.Admin - Account Page - query the new GET /api/tasks/runs to show all recent task runs for a specific account.
Summary by CodeRabbit