Skip to content

Merge pull request #417 from recoupable/codex/revert-artist-read-api#419

Merged
arpitgupta1214 merged 1 commit intomainfrom
test
Apr 9, 2026
Merged

Merge pull request #417 from recoupable/codex/revert-artist-read-api#419
arpitgupta1214 merged 1 commit intomainfrom
test

Conversation

@arpitgupta1214
Copy link
Copy Markdown
Collaborator

@arpitgupta1214 arpitgupta1214 commented Apr 9, 2026

revert: artist detail read endpoint


Summary by cubic

Reverts the artist detail read API. Removes GET /api/artists/[id] and all related handler, validation, data access, and tests.

  • Migration
    • GET /api/artists/:id and its OPTIONS handler are removed; calls now return 404.
    • Update any clients or integrations to stop calling this route.

Written for commit a6f64ab. Summary will update on new commits.

Summary by CodeRabbit

  • Revert
    • Removed the API endpoint for retrieving individual artist details by ID. This includes all associated validation, data transformation, and database query logic. Applications relying on this functionality will require updates.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4495b7b1-bde0-4e3b-80e3-b24da865affb

📥 Commits

Reviewing files that changed from the base of the PR and between 7705373 and a6f64ab.

⛔ Files ignored due to path filters (2)
  • lib/artists/__tests__/getArtistHandler.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**
  • lib/artists/__tests__/validateGetArtistRequest.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**
📒 Files selected for processing (5)
  • app/api/artists/[id]/route.ts
  • lib/artists/getArtistById.ts
  • lib/artists/getArtistHandler.ts
  • lib/artists/validateGetArtistRequest.ts
  • lib/supabase/accounts/selectAccountWithArtistDetails.ts

📝 Walkthrough

Walkthrough

This PR removes the complete API endpoint and supporting infrastructure for fetching a single artist by ID. It eliminates the Next.js route handler, business logic layer, request validation, database query helper, and associated type definitions across five files totaling 217 lines removed.

Changes

Cohort / File(s) Summary
API Route Layer
app/api/artists/[id]/route.ts
Removed the GET and OPTIONS handlers that handled single artist requests with CORS support.
Business Logic & Data Transformation
lib/artists/getArtistHandler.ts, lib/artists/getArtistById.ts
Removed the route handler orchestration and artist detail fetching logic, including the ArtistDetail interface and database transformation pipeline.
Request Validation & Data Access
lib/artists/validateGetArtistRequest.ts, lib/supabase/accounts/selectAccountWithArtistDetails.ts
Removed validation layer for artist requests with access control checks and the database query helper for fetching account details with artist-related associations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • sweetmantech

Poem

🗑️ Five files bow and fade away,
Artists' route no longer stays,
Simpler paths, cleaner lines—
Code removed, by design. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arpitgupta1214 arpitgupta1214 merged commit ee8aeaf into main Apr 9, 2026
4 of 6 checks passed
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
recoup-api Ready Ready Preview Apr 9, 2026 3:36pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant