feat: GET /api/artists/{id}/segments (replaces /api/artist/segments)

[arpitgupta1214]

Summary

Per , this PR introduces the nested per-artist list route for the segments surface and removes the legacy flat route outright (no alias window).

• Adds GET /api/artists/{id}/segments at app/api/artists/[id]/segments/route.ts.
• The artist account ID now comes from the path; the query schema only accepts page and limit (identical validation rules as before).
• Handler uses validateAuthContext() for authentication, then reuses the existing segments pagination logic.
• Relocates the handler, validator, getArtistSegments, and mapArtistSegments from lib/artist/ to lib/artists/segments/ for surface cohesion. Tests are co-located under lib/artists/segments/__tests__/.
• Deletes the legacy app/api/artist/segments/route.ts and the old lib/artist/* files in the same PR.

Response envelope ({ status, segments, pagination }) is unchanged.

Consumer coordination

• chat is the only known consumer; the matching chat migration will follow.
• A parallel POST /api/artists/[id]/segments PR is in flight in feat/api-post-segments on a sibling branch; this PR owns only the GET export so the two can coexist in the same route file post-merge.
• Matching docs PR to follow.

Test plan

• pnpm test — all 1907 tests pass (13 in the new lib/artists/segments suites).
• pnpm lint:check — 0 errors, no ESLint config changes.
• pnpm format:check — clean.
• Preview deploy smoke: GET /api/artists/{artistId}/segments returns the same envelope as the legacy route for an authenticated request.
• Confirm legacy GET /api/artist/segments returns 404 on the preview.

---

Summary by cubic

Adds GET /api/artists/{id}/segments to list an artist’s segments and removes the legacy GET /api/artist/segments. The artist ID now comes from the path; the response envelope is unchanged.

• New Features

  • New route at app/api/artists/[id]/segments/route.ts; handler reads the path id and validates path, auth, and query via validateGetArtistSegmentsRequest().
  • Query accepts only page and limit; validator renamed to validateGetSegmentsQuery() and ignores stray artist_account_id.
  • getArtistSegments now takes (artistId, { page, limit }); logic is co-located under lib/artists/segments/ with new tests.
  • Validator return types follow the Validated* convention: ValidatedGetSegmentsQuery, ValidatedGetArtistSegmentsRequest.

• Migration

  • Update clients from GET /api/artist/segments to GET /api/artists/{id}/segments.
  • Remove artist_account_id from query. Pass the artist ID in the path.

^{Written for commit d88d4c1. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
recoup-api	Ready	Preview	Apr 15, 2026 9:34pm

[coderabbitai]

Warning

Rate limit exceeded

@arpitgupta1214 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cd5a2165-0632-4a85-880f-39f05f53cc5f

📥 Commits

Reviewing files that changed from the base of the PR and between ec0008b and d88d4c1.

⛔ Files ignored due to path filters (2)

• lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**
• lib/artists/segments/__tests__/validateGetSegmentsQuery.test.ts is excluded by !**/*.test.*, !**/__tests__/** and included by lib/**

📒 Files selected for processing (7)

• app/api/artists/[id]/segments/route.ts
• lib/artist/getArtistSegmentsHandler.ts
• lib/artists/segments/getArtistSegments.ts
• lib/artists/segments/getArtistSegmentsHandler.ts
• lib/artists/segments/mapArtistSegments.ts
• lib/artists/segments/validateGetArtistSegmentsRequest.ts
• lib/artists/segments/validateGetSegmentsQuery.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/api-get-artists-segments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

1 issue found across 8 files

Confidence score: 4/5

• This PR is likely safe to merge: the only reported concern is maintainability/style, not a functional bug or regression risk.
• The most severe issue is in lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts, where the test suite exceeds the 100-line limit and should be split into smaller files or helpers to keep tests easier to read and maintain.
• Given the issue is code-style focused (despite high confidence), merge risk stays low-to-moderate rather than blocking.
• Pay close attention to lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts - oversized test file may reduce long-term readability and maintainability.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts">

<violation number="1" location="lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts:1">
P2: Custom agent: **Enforce Clear Code Style and Maintainability Practices**

Split this test suite into smaller files or extracted helpers; it exceeds the 100-line file limit.</violation>
</file>

Architecture diagram

sequenceDiagram
    participant Client as Consumer (Chat)
    participant Route as API Route ([id]/segments)
    participant Auth as validateAuthContext
    participant Val as Validators
    participant Lib as getArtistSegments
    participant DB as Supabase

    Note over Client,DB: NEW: Migrated Artist Segments Flow (Nested Route)

    Client->>Route: GET /api/artists/{id}/segments?page=1&limit=20
    
    Route->>Val: NEW: validateAccountParams(id)
    alt Invalid UUID
        Val-->>Route: 400 Bad Request
        Route-->>Client: 400 Error
    else Valid UUID
        Val-->>Route: validatedParams
    end

    Route->>Auth: NEW: validateAuthContext(request)
    alt Unauthorized / Invalid Session
        Auth-->>Route: 401/403 NextResponse
        Route-->>Client: Error Response
    else Valid Session
        Auth-->>Route: AuthContext
    end

    Route->>Val: CHANGED: validateGetSegmentsQuery(searchParams)
    Note right of Val: No longer expects artist_account_id in query
    alt Invalid page/limit
        Val-->>Route: 400 Bad Request
        Route-->>Client: 400 Error
    else Valid Query
        Val-->>Route: { page, limit }
    end

    Route->>Lib: getArtistSegments(artist_id, page, limit)
    
    Lib->>DB: selectArtistSegmentsCount(artist_id)
    DB-->>Lib: total_count
    
    Lib->>DB: selectArtistSegmentsWithDetails(artist_id, offset, limit)
    DB-->>Lib: raw_segments

    Lib->>Lib: mapArtistSegments(raw_segments)
    
    Lib-->>Route: { status: "success", segments, pagination }
    
    Route-->>Client: 200 OK + JSON Payload

Loading

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[cubic-dev-ai]

P2: Custom agent: Enforce Clear Code Style and Maintainability Practices

Split this test suite into smaller files or extracted helpers; it exceeds the 100-line file limit.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At lib/artists/segments/__tests__/getArtistSegmentsHandler.test.ts, line 1:

<comment>Split this test suite into smaller files or extracted helpers; it exceeds the 100-line file limit.</comment>

<file context>
@@ -0,0 +1,167 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { NextRequest, NextResponse } from "next/server";
+
</file context>

[cubic-dev-ai]

0 issues found across 3 files (changes from recent commits).

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.}

[cubic-dev-ai]

0 issues found across 2 files (changes from recent commits).

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.}

[cubic-dev-ai]

0 issues found across 3 files (changes from recent commits).

_{Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.}

[arpitgupta1214]

Smoke Test Results — GET /api/artists/{id}/segments

Tested against Vercel preview deployment.

#	Test	Expected	Actual	Result
1	Success (default pagination)	200	200	✅
2	Success (?page=1&limit=5)	200, limit=5	200, limit=5	✅
3	No auth (omit x-api-key)	401	401	✅
4	Invalid UUID path param	400	400	✅
5	Invalid pagination (?page=0)	400	400	✅
6	Invalid pagination (?limit=500)	400	400	✅

All 6 tests pass. Error messages are clear and consistent ("id must be a valid UUID", "Too small", "Too big").

Test artist (Kanye) has 0 segments so response shape was verified with empty segments: [] and pagination: { total_count: 0, page: 1, limit: 20, total_pages: 0 }.