feat: add open-agents schema port (Phase 0)#20
Merged
Conversation
Ports 7 tables from the open-agents POC's Drizzle schema (apps/web/lib/db/schema.ts) into recoupable production Supabase as the first phase of the broader migration to absorb the open-agents architecture into the main app. Tables: - sessions: agent runs bound to a sandbox + repo state - chats / chat_messages / chat_reads / shares: per-session chat threads - workflow_runs / workflow_run_steps: Vercel Workflow observability Decisions baked in (per migration plan): - text PKs (nanoid) preserved — type unification deferred to a later cleanup pass - user_id renamed to account_id and re-FK'd to existing accounts(id) (uuid). Open-agents' separate users + accounts tables are not ported; Privy identity already lives in accounts. - user_preferences NOT ported (preferences move to session cookies) - PR-related columns (auto_create_pr_override, pr_number, pr_status) dropped — auto-commit/push to default branch is the sole flow - GitHub-OAuth-token "accounts" table dropped — env-authenticated hard-coded GH account replaces per-user tokens - installations / linked_accounts / last_repo / public_usage_profile dropped — not needed in production - usage / usage_domain_leaderboard / usage_insights deferred to Phase 0b - Added chat_messages_chat_id_idx (open-agents schema didn't index it; production scale needs it for "get messages for chat" queries) RLS enabled on every new table per repo convention; no policies added, api consumes via service_role. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughTwo database migrations introduce the core persistence layer for an "open agents" system. The first migration creates tables for user sessions, chats, chat messages, read tracking, and share links. The second migration creates tables for workflow run tracking and per-step timing data. All tables include proper indexing and Row Level Security enablement. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Updates to Preview Branch (feat/open-agents-phase-0-schema-port) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@supabase/migrations/20260501000001_open_agents_workflow_runs.sql`:
- Around line 5-17: The workflow_runs table currently has independent FKs
(chat_id, session_id, account_id) which allow mismatched ownership; add
uniqueness on the parent pairs and replace the single-column FKs with composite
FKs to enforce the chain: create UNIQUE (id, session_id) on chats and UNIQUE
(id, account_id) on sessions, then change workflow_runs to drop the separate
REFERENCES on chat_id/session_id/account_id and add FOREIGN KEY (chat_id,
session_id) REFERENCES chats(id, session_id) and FOREIGN KEY (session_id,
account_id) REFERENCES sessions(id, account_id) (keeping columns non-null as
appropriate). Ensure the status/check, timestamps and defaults remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b394f4ca-bec5-4ea9-a3bd-d2a81c3637d2
📒 Files selected for processing (2)
supabase/migrations/20260501000000_open_agents_sessions_and_chats.sqlsupabase/migrations/20260501000001_open_agents_workflow_runs.sql
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="supabase/migrations/20260501000000_open_agents_sessions_and_chats.sql">
<violation number="1" location="supabase/migrations/20260501000000_open_agents_sessions_and_chats.sql:45">
P2: `updated_at` columns are added without an auto-update trigger, so timestamps will become stale on row updates.</violation>
<violation number="2" location="supabase/migrations/20260501000000_open_agents_sessions_and_chats.sql:71">
P2: Independent foreign keys on `chat_id`, `session_id`, and `account_id` don't enforce the ownership chain. The database will accept a `workflow_runs` row where `chat_id` points to a chat belonging to session A, while `session_id` is set to session B — a cross-ownership inconsistency.
Since `chats` already has a `session_id` column and `sessions` already has `account_id`, you can use composite foreign keys to enforce consistency. This requires adding unique indexes on the parent tables (`chats(id, session_id)` and `sessions(id, account_id)`) and replacing the independent FKs here with composite constraints:
```sql
CONSTRAINT workflow_runs_chat_session_fk
FOREIGN KEY (chat_id, session_id)
REFERENCES chats(id, session_id) ON DELETE CASCADE,
CONSTRAINT workflow_runs_session_account_fk
FOREIGN KEY (session_id, account_id)
REFERENCES sessions(id, account_id) ON DELETE CASCADE
```</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| -- Chat messages: full message parts as JSON | ||
| CREATE TABLE IF NOT EXISTS chat_messages ( | ||
| id TEXT PRIMARY KEY, | ||
| chat_id TEXT NOT NULL REFERENCES chats(id) ON DELETE CASCADE, |
There was a problem hiding this comment.
P2: Independent foreign keys on chat_id, session_id, and account_id don't enforce the ownership chain. The database will accept a workflow_runs row where chat_id points to a chat belonging to session A, while session_id is set to session B — a cross-ownership inconsistency.
Since chats already has a session_id column and sessions already has account_id, you can use composite foreign keys to enforce consistency. This requires adding unique indexes on the parent tables (chats(id, session_id) and sessions(id, account_id)) and replacing the independent FKs here with composite constraints:
CONSTRAINT workflow_runs_chat_session_fk
FOREIGN KEY (chat_id, session_id)
REFERENCES chats(id, session_id) ON DELETE CASCADE,
CONSTRAINT workflow_runs_session_account_fk
FOREIGN KEY (session_id, account_id)
REFERENCES sessions(id, account_id) ON DELETE CASCADEPrompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At supabase/migrations/20260501000000_open_agents_sessions_and_chats.sql, line 71:
<comment>Independent foreign keys on `chat_id`, `session_id`, and `account_id` don't enforce the ownership chain. The database will accept a `workflow_runs` row where `chat_id` points to a chat belonging to session A, while `session_id` is set to session B — a cross-ownership inconsistency.
Since `chats` already has a `session_id` column and `sessions` already has `account_id`, you can use composite foreign keys to enforce consistency. This requires adding unique indexes on the parent tables (`chats(id, session_id)` and `sessions(id, account_id)`) and replacing the independent FKs here with composite constraints:
```sql
CONSTRAINT workflow_runs_chat_session_fk
FOREIGN KEY (chat_id, session_id)
REFERENCES chats(id, session_id) ON DELETE CASCADE,
CONSTRAINT workflow_runs_session_account_fk
FOREIGN KEY (session_id, account_id)
REFERENCES sessions(id, account_id) ON DELETE CASCADE
```</comment>
<file context>
@@ -0,0 +1,106 @@
+-- Chat messages: full message parts as JSON
+CREATE TABLE IF NOT EXISTS chat_messages (
+ id TEXT PRIMARY KEY,
+ chat_id TEXT NOT NULL REFERENCES chats(id) ON DELETE CASCADE,
+ role TEXT NOT NULL
+ CHECK (role IN ('user', 'assistant')),
</file context>
…ow_runs, add updated_at triggers Three fixes from PR #20 bot review: 1. Drop the shares table. The /shared/[shareId] public-link UX is not in scope for production chat. Reversible if the feature is wanted later. 2. Drop session_id and account_id from workflow_runs. Both were redundant FKs derivable via chat -> session -> account joins, and independent FKs allowed cross-ownership inconsistency (workflow_run row could reference chat A while pointing session_id at session B). Keeping only chat_id makes the inconsistency impossible. 3. Add set_updated_at triggers on sessions, chats, and chat_reads. The existing convention is trigger_set_updated_at() (see 20250130200000_create_social_fans_table.sql); my first pass wrongly used trigger_set_timestamp() which targets accounts.timestamp, not generic updated_at columns. Without these triggers, updated_at would hold creation time forever. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 0 of the open-agents → main app migration. Ports the core agent/chat schema from open-agents' Drizzle definitions into Supabase migrations so api can absorb the open-agents backend in subsequent phases.
Tables added
Decisions baked into the schema
Type choices
Schema additions beyond the open-agents source
Security
Data migration
None. Per the plan, open-agents data starts fresh in Supabase (the live POC instance is being deprecated, not migrated).
Test plan
Up next
🤖 Generated with Claude Code
Summary by cubic
Phase 0 ports the core open-agents agent/chat schema into Supabase so the main app can absorb the open-agents backend. Adds
sessions,chats,chat_messages,chat_reads,workflow_runs, andworkflow_run_steps.account_idis a UUID FK to existingaccounts.id. Identity unified onaccounts; open-agentsusers, tokenaccounts, preferences, and PR-related columns are not ported.workflow_runsonly keepschat_id; removedsession_id/account_idto avoid cross-ownership bugs.sharespublic-link table (out of scope for production chat).chat_messages_chat_id_idx); cascade deletes on FKs; addupdated_attriggers onsessions,chats, andchat_reads.service_role). No data migration; data starts fresh in Supabase.Written for commit d80b81c. Summary will update on new commits.