Skip to content

Conversation

@lczyk
Copy link
Contributor

@lczyk lczyk commented Mar 18, 2025

Add warnings to prevent implicit conversions. It's a simple change and the library is already compliant.

cmake .. -DCGLM_USE_TEST=ON -DCGLM_SHARED=ON && make && make check passes

Thoughts?

@lczyk
Copy link
Contributor Author

lczyk commented Mar 18, 2025

So far unrelated CI failures ("Error: retrieving gpg key timed out.")

@recp recp merged commit 4b3dcce into recp:master Mar 19, 2025
173 of 188 checks passed
@recp
Copy link
Owner

recp commented Mar 19, 2025

Hi @MarcinKonowalczyk, thanks for your contributions the PR is merged 🚀


PS: I actually like implicit conversions especially for integers 🫣 but no need to have them in cglm ( for now especially )

@lczyk lczyk deleted the w-conversion branch March 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants