Resolve vec4 : glm_vec4_distance() to satisfy compiling on armv7#84
Merged
recp merged 5 commits intorecp:masterfrom Apr 27, 2019
Merged
Resolve vec4 : glm_vec4_distance() to satisfy compiling on armv7#84recp merged 5 commits intorecp:masterfrom
recp merged 5 commits intorecp:masterfrom
Conversation
Before it used armv8 only function thus it leads to build failed for Android with target of armv7 i.e. armeabi-v7a. This fixed that issue.
According to suggestion by recp at recp#82 (comment).
Contributor
Author
|
note I noticed 1 failed test result in bezier (pulled from the tip). |
Owner
|
Hi @haxpor Thanks for this PR. I have added this to travis: after_failure:
- cat ./test-suite.logwe should see what is wrong in travis's logs now |
Owner
this is weird, it passes on my local macos and macos on the travis-ci. My Linux VMs are not working for now, after fixed that I'll test it on Linux |
Contributor
Author
|
I pulled down the tip from |
Owner
|
SMC is matrix and vector multiplication. So there may be rounding errors, because SIMD registers (SSE/AVX....) do not have enough precision like single FPU... I was used this: assert_true(glm_eq(smc, Bs_plain));
assert_true(glm_eq(Bs, smc));it must be: test_assert_eqf(smc, Bs_plain);
test_assert_eqf(Bs, smc);Now all tests are passed. |
Owner
|
@haxpor thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed according to @recp 's suggestion of solution at #82 .
Test cases are added.
Tested on PC (Linux ubuntu 18.04 with SSE/SSE2/SSE3/SSE4 capable).
Tested on real Android device (Android 6.0, aarch64).