add PhpVersionConditionNodeVisitor (#7709)

TomasVotruba · web-flow · commit 7486ed589d45 · 2025-12-02T23:37:29.000Z
diff --git a/src/DependencyInjection/LazyContainerFactory.php b/src/DependencyInjection/LazyContainerFactory.php
@@ -103,6 +103,7 @@
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\ContextNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\GlobalVariableNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\NameNodeVisitor;
+use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\PhpVersionConditionNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\PropertyOrClassConstDefaultNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\StaticVariableNodeVisitor;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\SymfonyClosureNodeVisitor;
@@ -239,6 +240,7 @@ final class LazyContainerFactory
      */
     private const DECORATING_NODE_VISITOR_CLASSES = [
         ArgNodeVisitor::class,
+        PhpVersionConditionNodeVisitor::class,
         AssignedToNodeVisitor::class,
         SymfonyClosureNodeVisitor::class,
         ByRefReturnNodeVisitor::class,
diff --git a/src/NodeTypeResolver/Node/AttributeKey.php b/src/NodeTypeResolver/Node/AttributeKey.php
@@ -296,4 +296,6 @@ final class AttributeKey
     public const IS_INSIDE_BYREF_FUNCTION_LIKE = 'is_inside_byref_function_like';
 
     public const CLASS_CONST_FETCH_NAME = 'class_const_fetch_name';
+
+    public const PHP_VERSION_CONDITIONED = 'php_version_conditioned';
 }
diff --git a/src/NodeTypeResolver/PHPStan/Scope/NodeVisitor/PhpVersionConditionNodeVisitor.php b/src/NodeTypeResolver/PHPStan/Scope/NodeVisitor/PhpVersionConditionNodeVisitor.php
@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Ternary;
+use PhpParser\Node\Stmt\If_;
+use PhpParser\NodeVisitorAbstract;
+use Rector\Contract\PhpParser\DecoratingNodeVisitorInterface;
+use Rector\DeadCode\ConditionResolver;
+use Rector\DeadCode\ValueObject\VersionCompareCondition;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\PhpParser\NodeTraverser\SimpleNodeTraverser;
+
+final class PhpVersionConditionNodeVisitor extends NodeVisitorAbstract implements DecoratingNodeVisitorInterface
+{
+    public function __construct(
+        private readonly ConditionResolver $conditionResolver
+    ) {
+    }
+
+    public function enterNode(Node $node): ?Node
+    {
+        if (($node instanceof Ternary || $node instanceof If_) && $this->hasVersionCompareCond($node)) {
+            if ($node instanceof Ternary) {
+                $nodes = [$node->else];
+                if ($node->if instanceof \PhpParser\Node) {
+                    $nodes[] = $node->if;
+                }
+            } else {
+                $nodes = $node->stmts;
+            }
+
+            SimpleNodeTraverser::decorateWithAttributeValue($nodes, AttributeKey::PHP_VERSION_CONDITIONED, true);
+        }
+
+        return null;
+    }
+
+    private function hasVersionCompareCond(If_|Ternary $ifOrTernary): bool
+    {
+        if (! $ifOrTernary->cond instanceof FuncCall) {
+            return false;
+        }
+
+        $versionCompare = $this->conditionResolver->resolveFromExpr($ifOrTernary->cond);
+        return $versionCompare instanceof VersionCompareCondition;
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -296,4 +296,6 @@ final class AttributeKey`
`296`	`296`	`public const IS_INSIDE_BYREF_FUNCTION_LIKE = 'is_inside_byref_function_like';`
`297`	`297`
`298`	`298`	`public const CLASS_CONST_FETCH_NAME = 'class_const_fetch_name';`
	`299`	`+`
	`300`	`+ public const PHP_VERSION_CONDITIONED = 'php_version_conditioned';`
`299`	`301`	`}`