Skip to content

[Performance] [NodeTypeResolver] Reduce callable traverse usage on ContextNodeVisitor #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 3 commits into from
Jun 22, 2023
Merged

[Performance] [NodeTypeResolver] Reduce callable traverse usage on ContextNodeVisitor #4317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83130e
[NodeTypeResolver] Remove callable traverse on ContextNodeVisitor
samsonasik Jun 22, 2023
e383122
reduce instead
samsonasik Jun 22, 2023
d1e7bb5
reduce instead
samsonasik Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions packages/NodeTypeResolver/PHPStan/Scope/NodeVisitor/ContextNodeVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,11 @@ private function processContextInIssetOrUnset(Isset_|Unset_ $node): void

private function processContextInIf(If_|Else_|ElseIf_ $node): void
{
$this->simpleCallableNodeTraverser->traverseNodesWithCallable(
$node->stmts,
static function (Node $subNode): ?int {
if ($subNode instanceof Class_ || $subNode instanceof Function_ || $subNode instanceof Closure) {
return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
}

if ($subNode instanceof Break_) {
$subNode->setAttribute(AttributeKey::IS_IN_IF, true);
}

return null;
foreach ($node->stmts as $stmt) {
if ($stmt instanceof Break_) {
$stmt->setAttribute(AttributeKey::IS_IN_IF, true);
}
);
}
}

private function processContextInLoop(For_|Foreach_|While_|Do_ $node): void
Expand Down