Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Fixture;

use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Source\ParentWithNumber;

final class SkipOverrideFromParent extends ParentWithNumber
{
protected function getNumber($number)
{
$this->number = $number;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector\Source;

class ParentWithNumber
{
protected string $number;

abstract protected function getNumber($number);
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory;
use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
Expand All @@ -36,6 +37,7 @@ public function __construct(
private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser,
private readonly TypeFactory $typeFactory,
private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard
) {
}

Expand Down Expand Up @@ -121,6 +123,10 @@ function (Node $node) use ($paramName): bool {
continue;
}

if ($this->parentClassMethodTypeOverrideGuard->hasParentClassMethod($node)) {
return null;
}

$param->type = $paramType;
$hasChanged = true;
}
Expand Down