Skip to content

[NodeTypeResolver] Clean up anonymous class detection on NodeTypeResolver::getNativeType() #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Aug 6, 2023
Merged

[NodeTypeResolver] Clean up anonymous class detection on NodeTypeResolver::getNativeType() #4673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd1a55
[NodeTypeResolver] Clean up anonymous class detection on NodeTypeReso…
samsonasik Aug 6, 2023
b3f0900
remove doctrine test
samsonasik Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/NodeTypeResolver/NodeTypeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,8 @@ public function getNativeType(Expr $expr): Type
}

// cover anonymous class
if ($expr instanceof New_) {
$type = $this->resolveByNodeTypeResolvers($expr);
if ($expr instanceof New_ && $this->classAnalyzer->isAnonymousClass($expr->class)) {
$type = $this->nodeTypeResolvers[New_::class]->resolve($expr);
if ($type instanceof ObjectWithoutClassType) {
return $type;
}
Expand Down
28 changes: 0 additions & 28 deletions tests/Issues/DoNotReplaceUnknownClasses/DoNotReplaceUnknownClassesTest.php
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions tests/Issues/DoNotReplaceUnknownClasses/Fixture/skip_unknown_class_in_var.php.inc
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions tests/Issues/DoNotReplaceUnknownClasses/Fixture/skip_unknown_target_entity.php.inc
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions tests/Issues/DoNotReplaceUnknownClasses/config/configured_rule.php
View file
Open in desktop

This file was deleted.