Skip to content

[PostRector] Fix unused import not removed on empty generic class name exists #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 4 commits into from
Sep 13, 2023
Merged

[PostRector] Fix unused import not removed on empty generic class name exists #5012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a8076a
[PostRector] Fix unused import not removed on generic class name exists
samsonasik Sep 13, 2023
078bb28
[PostRector] Fix unused import not removed on generic class name exists
samsonasik Sep 13, 2023
f43ede7
[ci-review] Rector Rectify
actions-user Sep 13, 2023
ac93c3e
not make @see as part of text
samsonasik Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,9 @@ public function getGenericTagClassNames(): array
$resolvedClasses = [];

foreach ($genericTagValueNodes as $genericTagValueNode) {
$resolvedClasses[] = $genericTagValueNode->value;
if ($genericTagValueNode->value !== '') {
$resolvedClasses[] = $genericTagValueNode->value;
}
}

return $resolvedClasses;
Expand Down
1 change: 0 additions & 1 deletion packages/Config/RectorConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use Rector\Core\Contract\Rector\RectorInterface;
use Rector\Core\DependencyInjection\Laravel\ContainerMemento;
use Rector\Core\Exception\ShouldNotHappenException;
use Rector\Core\FileSystem\FilesystemTweaker;
use Rector\Core\NodeAnalyzer\ScopeAnalyzer;
use Rector\Core\Rector\AbstractScopeAwareRector;
use Rector\Core\ValueObject\PhpVersion;
Expand Down
2 changes: 1 addition & 1 deletion packages/NodeTypeResolver/Node/AttributeKey.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class AttributeKey
public const VIRTUAL_NODE = 'virtual_node';

/**
* Contains @see Scope
* @see Scope
* @var string
*/
public const SCOPE = 'scope';
Expand Down