Skip to content
/ rector-src Public

[NodeTypeResolver] Apply logic Mixed inside Union check on TypeFactory::uniquateTypes() #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Sep 27, 2025
Merged

[NodeTypeResolver] Apply logic Mixed inside Union check on TypeFactory::uniquateTypes() #7346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4dca63
[NodeTypeResolver] Apply logic Mixed inside Union check on TypeFactor…
samsonasik Sep 27, 2025
316df2e
[NodeTypeResolver] Apply logic Mixed inside Union check on TypeFactor…
samsonasik Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/NodeTypeResolver/PHPStan/Type/TypeFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ public function uniquateTypes(array $types, bool $keepConstant = false): array
$hasFalse = false;
$hasTrue = false;
foreach ($types as $type) {
// mixed only allowed to be standalone
if ($type instanceof MixedType) {
$type = new MixedType();
/** @var array<TType> */
return [new MixedType()];
}

$type = $this->normalizeObjectType($totalTypes, $type);
Expand Down Expand Up @@ -168,12 +170,6 @@ private function createUnionOrSingleType(array $types): Type
return $types[0];
}

foreach ($types as $type) {
if ($type instanceof MixedType) {
return new MixedType();
}
}

return new UnionType($types);
}

Expand Down
Loading