RemoveOverriddenValuesRector leaveNode() returned invalid value of type integer

[mxr576]

FYI, I am getting this error when only this rector is enabled. I'll try to spend some time to figure out how and why this happens exactly later.

$ ./vendor/bin/rector process -c .travis/rector.yml .drupal/web/core/modules/node/node.module --dry-run -v
Rector v0.4.9

/var/www/html/.drupal/web/core/modules/node/node.module
/var/www/html/.drupal/web/core/modules/node/node.module

In NodeTraverser.php line 168:
                                                      
  [LogicException]                                    
  leaveNode() returned invalid value of type integer  
                                                      

Exception trace:
 () at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:168
 PhpParser\NodeTraverser->traverseNode() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:146
 PhpParser\NodeTraverser->traverseNode() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
 PhpParser\NodeTraverser->traverseArray() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114
 PhpParser\NodeTraverser->traverseNode() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
 PhpParser\NodeTraverser->traverseArray() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91
 PhpParser\NodeTraverser->traverse() at /var/www/html/vendor/rector/rector/src/PhpParser/Node/Commander/NodeRemovingCommander.php:53
 Rector\PhpParser\Node\Commander\NodeRemovingCommander->traverseNodes() at /var/www/html/vendor/rector/rector/src/Rector/AbstractRector.php:140
 Rector\Rector\AbstractRector->afterTraverse() at /var/www/html/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:94
 PhpParser\NodeTraverser->traverse() at /var/www/html/vendor/rector/rector/src/Application/FileProcessor.php:110
 Rector\Application\FileProcessor->refactor() at /var/www/html/vendor/rector/rector/src/Application/RectorApplication.php:100
 Rector\Application\RectorApplication->Rector\Application\{closure}() at /var/www/html/vendor/rector/rector/src/Application/RectorApplication.php:124
 Rector\Application\RectorApplication->tryCatchWrapper() at /var/www/html/vendor/rector/rector/src/Application/RectorApplication.php:101
 Rector\Application\RectorApplication->runOnFileInfos() at /var/www/html/vendor/rector/rector/src/Console/Command/ProcessCommand.php:150
 Rector\Console\Command\ProcessCommand->execute() at /var/www/html/vendor/symfony/console/Command/Command.php:255
 Symfony\Component\Console\Command\Command->run() at /var/www/html/vendor/rector/rector/src/Console/Command/AbstractCommand.php:32
 Rector\Console\Command\AbstractCommand->run() at /var/www/html/vendor/symfony/console/Application.php:926
 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/vendor/symfony/console/Application.php:269
 Symfony\Component\Console\Application->doRun() at /var/www/html/vendor/rector/rector/src/Console/Application.php:73
 Rector\Console\Application->doRun() at /var/www/html/vendor/symfony/console/Application.php:145
 Symfony\Component\Console\Application->run() at /var/www/html/vendor/rector/rector/bin/rector:24

process [-d|--dry-run] [-a|--autoload-file AUTOLOAD-FILE] [-w|--with-style] [-e|--hide-autoload-errors] [-h|--help] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-c|--config CONFIG] [-l|--level LEVEL] [--debug] [--] <command> <source>...

Processed file: https://github.com/drupal/core/blob/8.6.13/modules/node/node.module

[TomasVotruba]

What's in rector.yml?

[mxr576]

Nothing special, only autoloading.
See:

• mxr576/drupal8-rector@8368d12
• https://travis-ci.org/mxr576/drupal8-rector/builds/515661651

[TomasVotruba]

I'll look into this

[TomasVotruba]

I took the file you've referenced and delete one method by another. This is the minimal method causing the issue:

function node_preprocess_html(&$variables) {
    // If on an individual node page or node preview page, add the node type to
    // the body classes.
    if (($node = \Drupal::routeMatch()->getParameter('node')) || ($node = \Drupal::routeMatch()->getParameter('node_preview'))) {
        if ($node instanceof NodeInterface) {
            $variables['node_type'] = $node->getType();
        }
    }
}

[TomasVotruba]

And this is the minimal code:

function someFunction() {
    if (($node = 1) || ($node = 2)) {
    }
}

[mxr576]

Thanks for investigating this!