Not wanted changed indentation with RenameClassRector

[soullivaneuh]

With the symfony40 set, I have plenty of diffs like this:

--- Original
+++ New
@@ -76,8 +76,8 @@
      *
      * @ORM\ManyToMany(targetEntity="AppBundle\Entity\Group")
      * @ORM\JoinTable(name="fos_user_user_group",
-     *     joinColumns={@ORM\JoinColumn(referencedColumnName="id")},
-     *     inverseJoinColumns={@ORM\JoinColumn(referencedColumnName="id")}
+     * joinColumns={@ORM\JoinColumn(referencedColumnName="id")},
+     * inverseJoinColumns={@ORM\JoinColumn(referencedColumnName="id")}
      * )
      */
     protected $groups;

The new indent is quite wrong to me, and I don't believe "fixing" indentation is the role of rector here, am I wrong?

[soullivaneuh]

The applied rector is: Rector\Rector\Class_\RenameClassRector

[soullivaneuh]

Oh I didn't see it seems to be fixed in cbdb6fa, sorry.

May we have a fix release then? It hurt a lot of levels actually. 👍

[soullivaneuh]

Hmm, the issue is not fixed to me with the master branch.

[TomasVotruba]

Hmm, the issue is not fixed to me with the master branch.

Thanks for testing!

It's annoying bug causes by PHPStan, they've removed more info about spacing during parsing docblocks, so I have to hack around it.

I'll look on it.

[soullivaneuh]

Causes by PHPStan? How PHPStan can interfer here? I'm just using the rector command. 🤔

[TomasVotruba]

See the commit you've referred → PR

I found it for you:

• PRs: [Symfony] Add MakeCommandLazyRector #1524, Make Symfony 4.3 + phpdoc-parser 0.3.4 compatible #1513
• issue: RenameClassRector wrongly aligns multiline comments #1522
• BC break in phpstan/phpdoc-parser: https://github.com/phpstan/phpdoc-parser/pull/26/files

[soullivaneuh]

All is working on master now, thanks! 👍

[TomasVotruba]

Thanks for confirming