[SOLID] Rector\SOLID\Rector\ClassConst\PrivatizeLocalClassConstantRector: false positive (turns constant to private that is publicly used)

[gnutix]

Adding the solid level gives me some false positive on constants :

1) src/SomeNamespace/ContentCacheManager.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -23,7 +23,7 @@
     /**
      * @var string
      */
-    public const CMS_CACHE_PATH = 'cms';
+    private const CMS_CACHE_PATH = 'cms';

     /**
      * @var string
    ----------- end diff -----------

Applied rectors:

 * Rector\SOLID\Rector\ClassConst\PrivatizeLocalClassConstantRector
 * Rector\CodingStyle\Rector\Namespace_\ImportFullyQualifiedNamesRector

Even though it is used in others classes, for example :

use SomeNamespace\ContentCacheManager;

final class LanguageFinder
{
    /**
     * @var string
     */
    public const CACHE_TAG_LANGS = ContentCacheManager::CMS_CACHE_PATH . '_langs';

[TomasVotruba]

What exact CLI command did you use?

[gnutix]

Sorry for the late answer! I use a composer rector-dry custom script defined as :

# composer.json
{
    "scripts": {
        "rector-dry": "vendor/bin/rector --ansi process --dry-run src/ tests/",
    }
}

[TomasVotruba]

I don't see a solid set there. Where do you add it?

If it's in rector.yaml, please provide its content.

[gnutix]

rector.yaml : https://gist.github.com/gnutix/4080142ecce07696035e19bdcb8c3d31

[TomasVotruba]

Could you try running with only that rule to isolate the problem?

[gnutix]

$ vendor/bin/rector process --dry-run --rule='Rector\SOLID\Rector\ClassConst\PrivatizeLocalClassConstantRector' src/SomeNamespace/ContentCacheManager.php
Rector v0.5.7
Config file: rector.yaml

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] Rector is done! 0 changed files

Only the specific rule is all good. But running the solid level is not :

$ vendor/bin/rector process --dry-run --level=solid src/BusinessLogic/Content/Cache/ContentCacheManager.php
Rector v0.5.7
Config file: rector.yaml

1) src/SomeNamespace/ContentCacheManager.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -23,7 +23,7 @@
     /**
      * @var string
      */
-    public const CMS_CACHE_PATH = 'cms';
+    private const CMS_CACHE_PATH = 'cms';

     /**
      * @var string
    ----------- end diff -----------

Applied rectors:

 * Rector\SOLID\Rector\ClassConst\PrivatizeLocalClassConstantRector
 * Rector\CodingStyle\Rector\Namespace_\ImportFullyQualifiedNamesRector

So I guess there's something conflicting between these two rectors.