Beautifying validation rules in Laravel

[sashabeton]

It would be great to create transformer from inline validation rules to array definition.

F.e.

'required|exists:' . Model::class . ',attribute|string'

can be transformed to

[  
  'required',  
  'exists:' . Model::class . ',attribute',  
  'string',  
]  

which is more beautiful, readable and editable.

Furthermore,

'exists:' . Model::class . ',attribute'

can be transformed to

\Illuminate\Validation\Rule::exists(Model::class, 'attribute')

[TomasVotruba]

Hi,

what Laravel version is this related to?

Any related PR from Laravel repository? Links to class where this was introduced? I don't use Laravel, so I have no idea what do you mean.

How does the code around the array look like? Transforming any array with 'string|string' to ['string', 'string'] everywhere would break lot of code :D

[sashabeton]

Of course all matches shouldn't be transformed :)

This is usually used in Illuminate\Foundation\Http\FormRequest extensions, in function rules

F.e.

<?php

use Illuminate\Foundation\Http\FormRequest;

class CustomRequest extends FormRequest
{
  public function rules(): array
  {
    return [
      'someAttribute' => 'required|string',
      // ...
    ];
  }
}

Laravel version that includes FormRequest - >=5.4

[TomasVotruba]

I see :). It seems pretty clear to me. If you want, I can guide you to create such a rule

[sashabeton]

It would be great!

[TomasVotruba]

Allright!

1. clone this repository
2. copy this file https://github.com/rectorphp/rector/blob/master/create-rector.yaml.dist to create-rector.yaml
3. complete all items + minimal code that is needed to be changed
4. run bin/rector create
5. send result as pull-request for further guidance