Skip to content

[coding-style] Rector\CodingStyle\Rector\Switch_\BinarySwitchToIfElseRector forgets a break statement ! #1783

@gnutix

Description

@gnutix
Subject Details
PHP version PHP 7.3.7-2+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Jul 25 2019 11:44:59) ( NTS )
Full Command vendor/bin/rector process var/rector_test.php --level=coding-style

Current Behaviour

Rector v0.5.8
Config file: rector.yaml

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

1 file with changes
===================

1) var/rector_test.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -1,12 +1,9 @@
 <?php
 $values = [];
-switch (count($values)) {
-    case 0:
-        $parsedValue = null;
-        break;
-    default:
-        $parsedValue = $values;
-        break;
+if (count($values) === 0) {
+    $parsedValue = null;
+} else {
+    $parsedValue = $values;
+    break;
 }
    ----------- end diff -----------

                                                                                                                        
 [OK] Rector is done! 1 changed files

Minimal PHP Code Causing Issue

<?php
$values = [];
switch (count($values)) {
    case 0:
        $parsedValue = null;
        break;
    default:
        $parsedValue = $values;
        break;
}

Expected Behaviour

This should produce :

<?php
$values = [];
switch (count($values)) {
    case 0:
        $parsedValue = null;
        break;
    default:
        $parsedValue = $values;
-       break;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions