Rector\Symfony\Rector\Form\FormIsValidRector adds "$form->isSubmitted()" where it shouldn't

[gnutix]

Subject	Details
PHP version	PHP 7.3.9-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Sep 2 2019 12:54:24) ( NTS )
Full Command	vendor/bin/rector --ansi --dry-run --debug process src

Running 0.5.13 on our entire codebase applies the following unexpected changes :

7) src/Controller/SomeController.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -30,7 +30,7 @@
         $form->handleRequest($request);

-        if (!$form->isSubmitted() || !$form->isValid()) {
+        if (!$form->isSubmitted() || !($form->isSubmitted() && $form->isValid())) {
    ----------- end diff -----------

8) src/Controller/SomeOtherController.php

    ---------- begin diff ----------
--- Original
+++ New
@@ -65,7 +65,7 @@
         $form->handleRequest($request);

         if ($form->isSubmitted()) {
-            if ($form->isValid()) {
+            if ($form->isSubmitted() && $form->isValid()) {
                // Some logic
             }
             // Some more logic
         }
    ----------- end diff -----------

[gnutix]

I've just ran rector again and this time it showed the rector being used : Rector\Symfony\Rector\Form\FormIsValidRector

[gnutix]

Added failing tests in 7a06337

[TomasVotruba]

Always send changes as pull-reqest, so we can see CI result and prevent conflicts.

I didn't know you can commit to master 🤣 need to fix that

[gnutix]

@TomasVotruba Okay, sorry! I thought failing test case wouldn't be a big deal to push on master directly. Btw, now I can't even push a branch anymore. That would be nice, so I don't have to have a fork...

[TomasVotruba]

No problem.

Please use fork, that's common practise for everybody else contributing Rector.

I didn't mean to add any access repository. I didn't know Github will grant such rights to collaborators. I only wanted to add review-rights.

[gnutix]

Confirm it's fixed on our codebase too. :) Thanks!

[TomasVotruba]

Thanks to your failing test cases it was much enjoyable to fix 👍

There might be some edge-case, when 2 forms are submitted to one action with same variable and but 2 methods, but I never saw that anywhere :D