TemplateAnnotationRector removes options in Route annotation

[stedekay]

Subject	Details
Rector version	v0.5.18
PHP version	PHP 7.3.3
Full Command	vendor/bin/rector process --set framework-extra-bundle-50 src

Current Behaviour

The rector removes the defaults and requirements options from the Route annotation. So it seems to me doing too much work.

 ---------- begin diff ----------                                                                          
--- Original                                                                                                  
+++ New                                                                                                       
@@ -13,15 +13,13 @@                                                                                               
    /**
      * @param mixed $category
      *
-     * @Route("/{category}", name="report_overview", defaults={"category" = null}, requirements={"category" = "\d+"})
-     * @Template("PAPPReportBundle:Report:report_list.html.twig")                                            
-     *                                                                                                       
+     * @Route("/{category}", name="report_overview")                                                               
      * @return array
      */
     public function indexAction($category = null)
     {
-        return [                                                                                             
+        return $this->render('PAPPReportBundle:Report:report_list.html.twig', [                                           
            'category' => $category,
-        ];                                                                                                   
+        ]);                                                                                                       
    }
}
    ----------- end diff -----------

Minimal PHP Code Causing Issue

<?php

declare(strict_types=1);

namespace PAPP\ReportBundle\Controller\Overview;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Routing\Annotation\Route;

final class TestController
{
    /**
     * @param mixed $category
     *
     * @Route("/{category}", name="report_overview", defaults={"category" = null}, requirements={"category" = "\d+"})
     * @Template("PAPPReportBundle:Report:report_list.html.twig")
     *
     * @return array
     */
    public function indexAction($category = null)
    {
        return [
            'category' => $category,
        ];
    }
}

Expected Behaviour

 ---------- begin diff ----------                                                                          
--- Original                                                                                                  
+++ New                                                                                                       
@@ -13,15 +13,13 @@                                                                                               
    /**
      * @param mixed $category
      *
      * @Route("/{category}", name="report_overview", defaults={"category" = null}, requirements={"category" = "\d+"})
-     * @Template("PAPPReportBundle:Report:report_list.html.twig")                                            
      *                                                                                                                                                                   
      * @return array
      */
     public function indexAction($category = null)
     {
-        return [                                                                                             
+        return $this->render('PAPPReportBundle:Report:report_list.html.twig', [                                           
            'category' => $category,
-        ];                                                                                                   
+        ]);                                                                                                       
    }
}
    ----------- end diff -----------

[TomasVotruba]

Could you send failing test case?

Just duplicate this file and complete your before/expected code:

rector/packages/Sensio/tests/Rector/FrameworkExtraBundle/TemplateAnnotationRector/TemplateAnnotationVersion5RectorTest.php

Line 28 in e2b34f1

yield [__DIR__ . '/Fixture/Version5/with_route_too.php.inc'];

[stedekay]

#2192 - Here is a failing test case. Don't know if its the way you wanted it.

[TomasVotruba]

As it's almost impossible to detect + keep these, I recommend using : over = as it's standard for all key:value annotatoins, also mentioned more often in the docs: https://symfony.com/doc/current/routing.html#extra-parameters

The rest is fixed though 👍 there were 3 missed annotations value

[stedekay]

Thx for your work!