TemplateAnnotationRector removes annotation without modifying return statement when delegating to another method

[stedekay]

Question

Like mentioned in #2215 the TemplateAnnotationRector removes the Template annotation when the the controller uses as private method in its return statement, but the private method still returns an array at the end:

    /**
     * @Route("/create", name="survey_create")
     * @Template("PAPPSurveyBundle:Survey:create.html.twig")
     *
     * @return array
     */
    public function createAction(Request $request, Party $currentParty)
    {
        $survey = $this->surveyHelper->createSurvey($currentParty);

        return $this->processForm($request, $currentParty, $survey, $this->generateUrl('survey_save'));
    }

    private function processForm(Request $request, Party $party, Survey $survey, $url)
    {
        ...

        return [
            'form' => $form->createView(),
        ];
    }

When I would fix this manually I would put the render Method into the private method. Is this something rector can handle or should this be fixed manually?

[TomasVotruba]

I think it's possible to delegate this to Rector.
Could you update the code with diff to show before/after? Just to be sure I understand you intention correctly

[stedekay]

Ah, okay. Here we go:

    /**
     * @Route("/create", name="survey_create")
-   * @Template("PAPPSurveyBundle:Survey:create.html.twig")
     *
     * @return array
     */
    public function createAction(Request $request, Party $currentParty)
    {
        $survey = $this->surveyHelper->createSurvey($currentParty);

        return $this->processForm($request, $currentParty, $survey, $this->generateUrl('survey_save'));
    }

    private function processForm(Request $request, Party $party, Survey $survey, $url)
    {
        ...

+       return $this->render('PAPPSurveyBundle:Survey:create.html.twig', [
-       return [
            'form' => $form->createView(),
        ];
    }