Rector adds whitespace in comments

[fsok]

Bug Report

Subject	Details
Rector version	dev-master@37cd497
Installed as	composer dependency

When a doc block line only contains a whitespace char, rector adds another whitespace char. When rector is run again this keeps happening - in each run another whitespace is added.

Minimal PHP Code Causing Issue

https://getrector.org/demo/0a8a1c75-b66b-4437-ab01-aa1ad7fca0c2

Expected Behaviour

No change of doc block.

[Aerendir]

The demo doesn't work as you describe: it simply removes a line and then adds it again; the same for the closing of the docblock.

[TomasVotruba]

Seems like it's \r\n vs \n problem.

[TomasVotruba]

@fsok I guess you're using Windows, right?

[TomasVotruba]

I tried to debug it for few hours, but I'm not very experienced with Windows spacing on Linux.

If you're able to send failing test case and fix it, I'd be happy to merged it.

[dimacros]

It happens to me now and I am using linux.
Output:

Example file:

namespace AppBundle\Domain\Shipment;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Embeddable
 */
final class TransportMeans
{
    /**
     * Marca del vehiculo
     *                                                                
     * @ORM\Column(type="string")
     */
    private $vehicleBrand;

    /**
     * Numero de placa del vehiculo que realiza el traslado
     *                                                                
     * @ORM\Column(type="string")
     */
    private $licensePlateNumber;
}

[fsok]

@TomasVotruba thanks for investigating.

No, I don't use Windows.

I added a failing test in #2943.

Seems to have something to do with this line: https://github.com/rectorphp/rector/blob/master/packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php#L224