Fully qualified name of function is imported as use instead of use function

[lulco]

Bug Report

Subject	Details
Rector version	dev-master@45caffd)
Installed as	git clone

I am trying to add some lines to my deploy.php (using https://github.com/deployphp/deployer). I wrote my own rector which do that, but when I turn on AUTO_IMPORT_NAMES, function Deployer\set is moved to imports like it is class, so I have:

use Deployer\set;
use function Deployer\set;

instead of

use function Deployer\set;

Minimal PHP Code Causing Issue

Failing test case #5520

Expected Behaviour

Functions are imported as use function

[TomasVotruba]

Do you have both statements imported?

use Deployer\set;
use function Deployer\set;

The function must be autoloaded, otherwise there is no way to find out if it's function or class.

[lulco]

I think yes, see failing test case. When it was not loaded it throws na error that it is not loaded so I add some require and then it acts like in my project.

[TomasVotruba]

I see, I'll look into it 👍 Thanks for the PR

[lulco]

Do you have both statements imported?

I read it again and you probably asked if both statements were added by rector at the same time. Then: no. Only use Deployer\set; was added. use function Deployer\set; was already there before rectoring

The function must be autoloaded, otherwise there is no way to find out if it's function or class.

I'm interesting in this statement. Why function must be autoloaded? If there is something() in code, it is always a function. Unless it is a constructor, but there have to be new keyword. Or am I missing something?

[TomasVotruba]

I thought I've replied this, but I can't see my comment. I'm sorry for delayed reply.

I'm interesting in this statement. Why function must be autoloaded? If there is something() in code, it is always a function. Unless it is a constructor, but there have to be new keyword. Or am I missing something?

That's how it works now, but it can be improved as you suggest.

This is the line that decides that unimported function that does not exists is treated as a class:

rector/rules/coding-style/src/Node/NameImporter.php

Lines 212 to 232 in 59e1063

	private function isNonExistingClassLikeAndFunctionFullyQualifiedName(Name $name): bool
	{
	if (! $name instanceof FullyQualified) {
	return false;
	}
	// can be also in to be renamed classes
	$classOrFunctionName = $name->toString();
	$oldToNewClasses = $this->renamedClassesCollector->getOldToNewClasses();
	if (in_array($classOrFunctionName, $oldToNewClasses, true)) {
	return false;
	}
	// skip-non existing class-likes and functions
	if (ClassExistenceStaticHelper::doesClassLikeExist($classOrFunctionName)) {
	return false;
	}
	return ! function_exists($classOrFunctionName);
	}

The method could be split into 2 and check for function node in "If there is something() in code, it is always a function" way

[lulco]

Yes, you did in PR with failing test for this issue. No problem for delay, I will have at least two months of vacation (almost fully without computer) so I can’t implement it now.

[TomasVotruba]

No problem 👍 That sounds cool 😮 Where you heading for early summer? 😎

[lulco]

Haha nothing like that. Second baby will born soon, so I will be full-time father for the first one :)

[TomasVotruba]

Oh, congrats and have fun! 🎉 That's million times better than any vacation 👶

[samsonasik]

It seems fixed by #5755