dev-main cause [ERROR] Could not process some files

[samsonasik]

Bug Report

Subject	Details
Rector version	dev-main

Minimal PHP Code Causing Issue

Got error like this on run on CodeIgniter 4 system directory:

3) system/Model.php:799

    ---------- begin diff ----------
@@ @@
             return parent::__get($name);
         }

-        if (isset($this->builder()->{$name})) {
-            return $this->builder()->{$name};
-        }
-
-        return null;
+        return $this->builder()->{$name} ?? null;
     }

     /**
    ----------- end diff -----------

Applied rules:
 * IfIssetToCoalescingRector


                                                                                                                        
 [ERROR] Could not process some files, due to:                                                                          
         "Child process error: ".                                                                                       
                                                                                                                        

Expected Behaviour

Should not erorr. the error is only show once tho, run once more with fix already cover it. As I see, RemoveUnusedVariableAssignRector may need refactor, so even this patch should not needed.

• [DeadCode][CodeQuality] Fix infinite loop on RemoveUnusedVariableAssignRector+SimplifyIfElseToTernaryRector rector-src#3933

[samsonasik]

The source of issue seems the following stmts:

        Else_::class,
        ElseIf_::class,
        Catch_::class,
        Finally_::class

are indirect next node after If_ or TryCatch_, which we currently flag above stmts stmt_key as 0 as no prev and next stmts from parent stmts.

Previously, with next and prev attribute, it always be "next" node of If_ or TryCatch_

[samsonasik]

I found the file that cause a crash:

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/rector process system/CLI/CLI.php    
 0/1 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%file is 

                                                                                                                        
 [ERROR] Could not process some files, due to:                                                                          
         "Child process error: ".                                                                                       

I will look check it.

[samsonasik]

Reproduced with 2 rules;

    $rectorConfig->rule(RemoveUnusedVariableAssignRector::class);
    $rectorConfig->rule(AddDefaultValueForUndefinedVariableRector::class)

Ref https://getrector.com/demo/de8f1ba8-0910-45f1-8d2f-ea987900cf17