Incorrect behavior of RestoreDefaultNullToNullableTypePropertyRector

[simPod]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/492d4ef9-bfd2-4a66-9f64-376697f98ad2

<?php

final readonly class A
{
    public B|null $display;

    public function __construct(
        string|null $display = null,
    ) {
        if ($display === null) {
            $this->display = null;
        } else {
            $this->display = $display;
        }
    }
}

Responsible rules

• RestoreDefaultNullToNullableTypePropertyRector

Expected Behavior

1. it shouldn't add default values to readonly properties https://3v4l.org/TLaUT#v8.2.7
2. The property is initialized in constructor so it should't try to add a default value

[TomasVotruba]

Thank you for your report and demo link!

We'll need a failing test case in a pull-request, so we have it covered in Rector.
You can click "Create a Test" button at demo page.

[samsonasik]

@simPod if you have time, could you try provide a patch? It should be a matter of check:

        if ($node->isReadonly()) {
            return null;
        }

[samsonasik]

Resolved at rectorphp/rector-src#4479