Incorrect behavior of ReadOnlyClassRector

[fvozar]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/e997b6f2-3398-44a6-a278-b7f04b034705

<?php

class A {}


class B extends A
{
    
    public function __construct(
        private string $foo
    ) {}
    
    public function run()
    {
        return $this->foo;
    }
}

Responsible rules

• ReadOnlyPropertyRector
• ReadOnlyClassRector
• FinalizeClassesWithoutChildrenRector

Result from Rector

- class B extends A
+ final readonly class B extends A

Expected Behavior

Class B shouldn't be readonly because PHP throws a "Fatal error: Readonly class B cannot extend non-readonly class A".

[dkarlovi]

FWIW, same problem with Symfony controllers extending from Symfony\Bundle\FrameworkBundle\Controller\AbstractController.

Interestingly, it doesn't do it for commands which extend from Symfony\Component\Console\Command\Command.

[samsonasik]

@TomasVotruba the $scope->getClassReflection() on Class_ somehow got null on multiple rules, probably due to context fill on PHPStanNodeScopeResolver;

rector/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

Lines 401 to 405 in 22756db

	// on refresh, remove entered class avoid entering the class again
	if ($isScopeRefreshing && $mutatingScope->isInClass() && !$isAnonymous) {
	$context = $this->privatesAccessor->getPrivateProperty($mutatingScope, 'context');
	$this->privatesAccessor->setPrivateProperty($context, 'classReflection', null);
	}

so it got null after passed.