AddParamTypeFromPropertyTypeRector doesn't respect inheritance

[AAllport]

Bug Report

Subject	Details
Rector version	v0.17.0
laravel/framework	v10.16.1
laravel/socialite	v5.8.0
socialiteproviders/manager	v4.3.0

AddParamTypeFromPropertyTypeRector does not respect inheritance.

When using SetList::TYPE_DECLARATION in a project that has classes extending those from 3rd parties,
Rector will attempt to add a type declaration to functions that extend from their parent, triggering a fatal error due to the signature mismatching.

Minimal PHP Code Causing Issue

Difficult to create a demo since this issue relies on a class being read-only.
However, the above screenshot was from the following (abbreviated) code

<?php

namespace App\Providers;

class XeroSocialiteProvider extends \SocialiteProviders\Manager\OAuth2\AbstractProvider
{
    protected function getUserByToken($token)
    {
        //
    }
}

Expected Behaviour

Rector should not add the string type to the param, as it breaks the change.
Or even better, Rector should inspect the inheritance chain to fix it if it has broken (eg, due to an upgrade).

[samsonasik]

Could you reproduce at https://getrector.com/demo ? If that reproducible, then you can click "Create a Test" button at the demo result page

[AAllport]

The issue with reproducing is it relies on Rector not having the ability to touch the parent (like with a composer package)
Is that possible in the test builder?

I have put a little domo here - https://getrector.com/demo/00bc6d6c-49ce-40dd-aef0-2a960c82a022
But I'm not sure if the correct output would be for Rector to amend the abstract parent, or not touch it at all.

For the case I'm describing, please see the following screenshot, of demo.php, and demo1.php on the left and right, respectively.

When running rector process demo.php, it adds the string type to XeroSocialiteProvider::getUserByToken
On its own, this isn't nessasarally incorrect, as it is a string, that could be added.
However, it breaks the inheritance chain.

[AAllport]

Oh wow, that was quick,
Thankyou so much!

Absolutely love the work y'all are doing, such a great plus to keep our codebase nice and consistent!

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.