Incorrect behavior of combined LongArrayToShortArrayRector, SensitiveConstantNameRector, AddParamBasedOnParentClassMethodRector

[klimslim]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/dc7e8fb1-8243-4b93-b2aa-5a0b61d76dcd

<?php

class Foo{
    public function baz($default = array()) {
        return implode($default);
    }
}

class Bar extends Foo {
    public function baz() {
        return parent::baz();
    }
}

Responsible rules

• LongArrayToShortArrayRector

• SensitiveConstantNameRector

• AddParamBasedOnParentClassMethodRector

Expected Behavior

@@ -1,13 +1,13 @@
 <?php
 
 class Foo{
-    public function baz($default = array()) {
+    public function baz($default = []) {
         return implode($default);
     }
 }
 
 class Bar extends Foo {
-    public function baz() {
+    public function baz($default = []) {
         return parent::baz();
     }
 }

But instead, a syntactically incorrect PHP code is produced:
https://3v4l.org/obEd9

[samsonasik]

That should be resolved at PR:

• [Php73][Php80] Handle empty long array syntax default value on SensitiveConstantNameRector+AddParamBasedOnParentClassMethodRector rector-src#4837

demo site will be updated on next 5 hours, you can try:

composer config minimum-stability dev
composer config prefer-stable true
composer require --dev rector/rector:dev-main

[klimslim]

Thanks!
Sorry for not checking locally.

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.