ClosureToArrowFunctionRector not working as expected with compact

[melicerte]

Bug Report

Subject	Details
2.1.1	Rector 2.1.1

When converting callback to arrow functions, if the callback uses parameters which are exclusively used in a compact call, it removes the parameters, but compact does not know about them anymore (See example code below).

Minimal PHP Code Causing Issue

Here it is: https://getrector.com/demo/71bd1985-bd97-4cda-af96-440b328bb962

Expected Behaviour

Maybe the best call would be to convert compact calls to explicit array, but it does more than what the rule says.
Or maybe Rector should not convert this callback at all.
I'm not pretty sure what is the best solution here, but happy to talk about it.

[samsonasik]

There is CompactToVariablesRector rule tho, while this should be skipped, you can register the CompactToVariablesRector rule early for now

https://getrector.com/demo/c5bf7c11-92a3-44d5-afd5-a0186444923d

I will check this to be skipped :)

[melicerte]

That was fast, thank you very much @samsonasik