RemoveAlwaysElseRector is not fully refactoring code

[u01jmg3]

Bug Report

Subject	Details
Rector version	2.2.8

RemoveAlwaysElseRector is not formatting code correctly or completing what I would expect it to refactor.

Minimal PHP Code Causing Issue

https://getrector.com/demo/6b25de4e-f818-4e12-95c4-62620da5445d

-        if ($value == 0) {
-            return $value;
-        } elseif ($formatForEmail) {
-            $value .= '|' . 1;
-
-            return $time_context . '  //  ' . $direction . $value . ' minute(s)';
-        } else {
+        if ($value == 0) {
+            return $value;
+        }
+        if ($formatForEmail) {
+            $value .= '|' . 1;
+            return $time_context . '  //  ' . $direction . $value . ' minute(s)';
+        }
+        else {
             return $value;
         }

Expected Behaviour

Highlights

• Final else branch can be refactored further
• A newline should be inserted between if conditions
• The newline present in the original code should be maintained after the refactor (i.e. the one that comes after $value .= '|' . 1;)

-        if ($value == 0) {
-            return $value;
-        } elseif ($formatForEmail) {
-            $value .= '|' . 1;
-
-            return $time_context . '  //  ' . $direction . $value . ' minute(s)';
-        } else {
-             return $value;
-        }
+        if ($value == 0) {
+            return $value;
+        }
+
+        if ($formatForEmail) {
+            $value .= '|' . 1;
+
+            return $time_context . '  //  ' . $direction . $value . ' minute(s)';
+        }
+
+        return $value;

[samsonasik]

new blank line is by preference, if you want, you can apply NewlineAfterStatementRector,

https://getrector.com/rule-detail/newline-after-statement-rector

on changed node, since it uses line atrribute, when extract if else, the double run is needed.

For removing last else, run twice should apply.

[u01jmg3]

• Double run didn't work
• The newline in the original code should at least be maintained, no? On large code blocks using many newlines, every newline is removed by this Rector change, yet they exist in the original code!

[samsonasik]

Oh, yeah, the removal line part, that's expected, as reprinting it is usually removing lines, this is part of php-parser known drawback https://github.com/rectorphp/rector/?tab=readme-ov-file#known-drawbacks

You may can use coding standard tools for that :)

[calebdw]

Double run didn't work

Make sure you clear the cache in between runs