StaticCallOnNonStaticToInstanceCallRector rule fails to check static context

[ActualFab]

Bug Report

Subject	Details
Rector version	v2.3.6

Given a laravel Model with a scope, we can invoke it using both $modelnstance->scope() and Model::scope().
Now given that this model also has a static function to perfom some task, within this function we MUST use Model::scope() since the method itself is static.

A rector pass will trigger the StaticCallOnNonStaticToInstanceCallRector rule on that line and propose to change it to $this->scope()

Minimal PHP Code Causing Issue

Not an easy one to reproduce in demo, since it involves Laravel Proxy Magic.

Expected Behaviour

This rule should additionally make sure that the eventual method context is not static before applying/proposing the fix.

---

First time ever I run into an issue with rector and I use it on quite large code bases, so thank you and keep up the good work !

Cheers

[samsonasik]

Without reproducible repo, we can't help on this, you can skip on your own specific use case.

https://getrector.com/documentation/ignoring-rules-or-paths

Feel free to provide failing fixture when you have a chance.

Thank you for understanding.

[ActualFab]

It's an edge case, so don't bother, though I don't think you need more than my description to understand that if the rule apply on $this when inside of a static method of the same class, it can never work.

[nikspyratos]

I ran into this myself. Had Claude make a reproduction of the issue.

https://github.com/nikspyratos/rector-static-call-repro

Can we reopen this @samsonasik ?

If I'm reading changes to the file correctly, I believe it's a regression from this PR from Feb 3rd: https://github.com/rectorphp/rector-src/pull/7876/changes

The checks added don't account for the caller method itself being a static method.

[samsonasik]

Thank you @nikspyratos for reproducible repo, reopened 👍