Skip to content

Keep an empty docblock as is #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaal wants to merge 4 commits into from
Closed

Keep an empty docblock as is #3394

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5d2b82
Keep an empty docblock as is
May 20, 2020
48e83ea
Remove the function isPhpDocNodeEmpty() that is no longer being used
May 21, 2020
82ea940
Remove an unused use statement
May 21, 2020
500dc2b
Merge remote-tracking branch 'origin/master' into do-not-remove-empty…
May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions packages/better-php-doc-parser/src/Printer/PhpDocInfoPrinter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

use Nette\Utils\Strings;
use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode;
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTextNode;
use PHPStan\PhpDocParser\Lexer\Lexer;
Expand Down Expand Up @@ -122,11 +121,6 @@ public function printFormatPreserving(PhpDocInfo $phpDocInfo): string

private function printPhpDocNode(AttributeAwarePhpDocNode $attributeAwarePhpDocNode): string
{
// no nodes were, so empty doc
if ($this->isPhpDocNodeEmpty($attributeAwarePhpDocNode)) {
return '';
}

$this->currentTokenPosition = 0;

$output = '';
Expand Down Expand Up @@ -158,25 +152,6 @@ private function removeExtraSpacesAfterAsterisk(string $phpDocString): string
return Strings::replace($phpDocString, '#([^*])\*[ \t]+$#sm', '$1*');
}

private function isPhpDocNodeEmpty(PhpDocNode $phpDocNode): bool
{
if (count($phpDocNode->children) === 0) {
return true;
}

foreach ($phpDocNode->children as $phpDocChildNode) {
if ($phpDocChildNode instanceof PhpDocTextNode) {
if ($phpDocChildNode->text !== '') {
return false;
}
} else {
return false;
}
}

return true;
}

private function printNode(
AttributeAwareNodeInterface $attributeAwareNode,
?StartEndValueObject $startEndValueObject = null,
Expand Down