Add vat_number to ShippingAddress resource#337
Merged
Conversation
This is a supported attribute according to https://dev.recurly.com/docs/create-shipping-address-on-an-account. Without this, setting the shipping address when creating it has not effect.
Contributor
|
@alvinlindstam looks good at first glance! @joannasese will review it. |
Author
|
Great, thanks. Any chance of a new release with this soonish? |
Contributor
|
@alvinlindstam we'll get a patch out this month. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a supported attribute according to https://dev.recurly.com/docs/create-shipping-address-on-an-account.
Without this, setting the shipping address when creating it has not effect.
I have no idea if this is a sufficient change, but it does seem to make the attribute be added when testing it.