Skip to content

Add tax_code to plan, add on and adjustment#97

Merged
cbarton merged 1 commit intomasterfrom
jh-digital_services_vat_2015_api
Dec 3, 2014
Merged

Add tax_code to plan, add on and adjustment#97
cbarton merged 1 commit intomasterfrom
jh-digital_services_vat_2015_api

Conversation

@judith
Copy link
Copy Markdown
Contributor

@judith judith commented Nov 25, 2014

Used in tax calculations for VAT 2015 and Avalara integration taxes only.

Valid tax_code values for VAT 2015 taxes are unknown, digital and physical. Valid tax_code values for Avalara integration taxes can be found in the Avalara documentation.

Approvers: @cbarton

Tests:
On a site with VAT 2015 and Avalara integration taxes enabled:

  • Create/Update a plan, add_on and adjustment with a valid tax_code and verify there isn't an error
  • Get the created/updated plan, add_on and adjustment and verify that the tax_code is returned in the results
  • Attempt to create/update a plan, add_on and adjustment with an invalid tax_code and verify that an error is returned in the results
    On a site without VAT 2015 and Avalara integration taxes enabled:
  • Get a plan, add_on and adjustment and verify that the tax_code is not returned in the results
  • Attempt to create/update a plan, add_on and adjustment with a tax_code and verify that an error is returned in the results

Used in tax calculations for VAT 2015 and
Avalara integration taxes.
cbarton added a commit that referenced this pull request Dec 3, 2014
Add tax_code to plan, add on and adjustment
@cbarton cbarton merged commit 7a2ea00 into master Dec 3, 2014
@cbarton cbarton deleted the jh-digital_services_vat_2015_api branch December 3, 2014 18:49
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

V2 V2 Client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants