Skip to content

Improved code readability for parsing true, false and null. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Improved code readability for parsing true, false and null. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions Source/ULibs.TinyJsonDeser/JsonDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,7 @@ private static bool TryParseBool(string json, ref int offset, out bool output)
switch (json[offset])
{
case 't':
if (offset < json.Length - 3 &&
json[offset + 1] == 'r' &&
json[offset + 2] == 'u' &&
json[offset + 3] == 'e')
if (offset < json.Length - 3 && json.Substring(offset, 4) == "true")
{
offset += 4;
output = true;
Expand All @@ -260,11 +257,7 @@ private static bool TryParseBool(string json, ref int offset, out bool output)
break;

case 'f':
if (offset < json.Length - 4 &&
json[offset + 1] == 'a' &&
json[offset + 2] == 'l' &&
json[offset + 3] == 's' &&
json[offset + 4] == 'e')
if (offset < json.Length - 4 && json.Substring(offset, 5) == "false")
{
offset += 5;
return true;
Expand All @@ -279,11 +272,7 @@ private static bool TryParseBool(string json, ref int offset, out bool output)

private static bool TryParseNull(string json, ref int offset)
{
if (offset < json.Length - 3 &&
json[offset] == 'n' &&
json[offset + 1] == 'u' &&
json[offset + 2] == 'l' &&
json[offset + 3] == 'l')
if (offset < json.Length - 3 && json.Substring(offset, 4) == "null")
{
offset += 4;
return true;
Expand Down
6 changes: 6 additions & 0 deletions Source/ULibs.TinyJsonDeser/RELEASENOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# ULibs.TinyJsonDeser release notes

## 1.0.1

### Features

- Improved code readability for parsing `true`, `false` and `null`.

## 1.0.0

### Features
Expand Down