Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Sep 16, 2025

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

jiridanek and others added 9 commits September 12, 2025 23:19
…ious runtimes and environments (opendatahub-io#2441)

- chore(manifests): add feast to manifests
- chore(tests): update tests so that they don't fail with feast now present
… 2.20, `Boto3` to 1.40.6, `Kfp` to 2.14 across those UBI9 Python 3.12 images that permit it (opendatahub-io#1875)

- relock `pylock.toml` on Python 3.12; bump `Kfp` to 2.14.1, `google-cloud-storage` to 3.3.0, `protobuf` to 6.31.1, add `click-option-group`
…6.4 (opendatahub-io#2455)

* Add CUDA 12.8 base images

* Add Tekton files for CUDA 12.8

* Update base-images/cuda/12.8/ubi9-python-3.12/Dockerfile.cuda

Co-authored-by: aTheo <atheodorak@outlook.com>

* Update base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda

Co-authored-by: aTheo <atheodorak@outlook.com>

* Update base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda

Co-authored-by: aTheo <atheodorak@outlook.com>

* Change CUDNN_VERSION on ubi9-python-3.12 CUDA base image

* Add different name for CUDA 12.8 Tekton pipeline files

* Add Tekton files for ROCm 6.4

* Fix wrong path on ROCm 6.4 pipeline

* Fix ROCm 6.4 pipeline names

---------

Co-authored-by: aTheo <atheodorak@outlook.com>
appstudio.openshift.io/component: odh-base-image-cuda-py312-c9s
pipelines.appstudio.openshift.io/type: build
name: odh-base-image-cuda-12-8-py312-c9s-on-pull-request
namespace: open-data-hub-tenant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atheo89 I'm confused, is it correct to have this in rhds or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I’ve given up… we’re getting a lot of Tekton files coming from upstream into RHDS. The good thing is they don’t actually break anything (but they add some noise). Another plus is that they don’t make it into the release branch. Moulali mentioned he has an idea for how to prevent these files from coming downstream.

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images c90b266 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89 atheo89 merged commit 98f8d09 into red-hat-data-services:main Sep 16, 2025
26 of 52 checks passed
@atheo89 atheo89 deleted the sync-qwe branch October 13, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants