-
Notifications
You must be signed in to change notification settings - Fork 24
Sync rhds:main from odh:main
#1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ious runtimes and environments (opendatahub-io#2441) - chore(manifests): add feast to manifests - chore(tests): update tests so that they don't fail with feast now present
… 2.20, `Boto3` to 1.40.6, `Kfp` to 2.14 across those UBI9 Python 3.12 images that permit it (opendatahub-io#1875) - relock `pylock.toml` on Python 3.12; bump `Kfp` to 2.14.1, `google-cloud-storage` to 3.3.0, `protobuf` to 6.31.1, add `click-option-group`
…r dependencies in pyproject.toml files (opendatahub-io#2448)
Remove revision from output-image opt
Revert changes on output-image
…6.4 (opendatahub-io#2455) * Add CUDA 12.8 base images * Add Tekton files for CUDA 12.8 * Update base-images/cuda/12.8/ubi9-python-3.12/Dockerfile.cuda Co-authored-by: aTheo <atheodorak@outlook.com> * Update base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda Co-authored-by: aTheo <atheodorak@outlook.com> * Update base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda Co-authored-by: aTheo <atheodorak@outlook.com> * Change CUDNN_VERSION on ubi9-python-3.12 CUDA base image * Add different name for CUDA 12.8 Tekton pipeline files * Add Tekton files for ROCm 6.4 * Fix wrong path on ROCm 6.4 pipeline * Fix ROCm 6.4 pipeline names --------- Co-authored-by: aTheo <atheodorak@outlook.com>
| appstudio.openshift.io/component: odh-base-image-cuda-py312-c9s | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-cuda-12-8-py312-c9s-on-pull-request | ||
| namespace: open-data-hub-tenant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atheo89 I'm confused, is it correct to have this in rhds or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I’ve given up… we’re getting a lot of Tekton files coming from upstream into RHDS. The good thing is they don’t actually break anything (but they add some noise). Another plus is that they don’t make it into the release branch. Moulali mentioned he has an idea for how to prevent these files from coming downstream.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: