forked from opendatahub-io/notebooks
-
Notifications
You must be signed in to change notification settings - Fork 24
Sync rhds:main from odh:main
#1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
49ab978
RHAIENG-670: feat(pyproject): add feast~=0.53.0 dependency across var…
jiridanek 51210ab
RHAIENG-722: chore(CVEs): bump `TensorFlow` to 2.20, `TensorBoard` to…
jiridanek 21ad727
opendatahub-io/notebooks#2222: tidy(pyproject.toml): standardize quot…
jiridanek dde3132
Remove revision from output-image opt
atheo89 842b79e
Merge pull request #2458 from atheo89/check-revision
atheo89 2d3dbeb
Revert changes on output-image
atheo89 f96d603
Merge pull request #2459 from atheo89/check-revision
atheo89 a07673f
RHAIENG-286: Add base images for CUDA 12.8 and Tekton files for ROCm …
daniellutz c90b266
Merge branch 'main' of https://github.com/opendatahub-io/notebooks in…
atheo89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
.tekton/odh-base-image-cuda-12-8-py312-c9s-pull-request.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # yamllint disable-file | ||
| # This pipeline is autogenerated by scripts/generate_pull_request_pipelineruns.py | ||
| --- | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: 'true' | ||
| pipelinesascode.tekton.dev/max-keep-runs: '3' | ||
| pipelinesascode.tekton.dev/on-comment: ^/kfbuild\s+(all|odh\-base\-image\-cuda\-py312\-c9s|base\-images/cuda/12\.8/c9s\-python\-3\.12) | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| event == "pull_request" && target_branch == "main" && ( "base-images/cuda/12.8/c9s-python-3.12/**".pathChanged() || ".tekton/odh-base-image-cuda-12-8-py312-c9s-pull-request.yaml".pathChanged() ) | ||
| && body.repository.full_name == "opendatahub-io/notebooks" | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-cuda-py312-c9s | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-cuda-12-8-py312-c9s-on-pull-request | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| timeouts: | ||
| pipeline: 3h | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-cuda-py312-c9s:on-pr-{{revision}} | ||
| - name: image-expires-after | ||
| value: 5d | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - linux/arm64 | ||
| - name: dockerfile | ||
| value: base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda | ||
| - name: path-context | ||
| value: . | ||
| pipelineRef: | ||
| name: multiarch-pull-request-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-cuda-py312-c9s-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| #test2 | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: "false" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && ( "base-images/cuda/12.8/c9s-python-3.12/**".pathChanged() || ".tekton/odh-base-image-cuda-12-8-py312-c9s-push.yaml".pathChanged() ) | ||
| creationTimestamp: | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-cuda-py312-c9s | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-cuda-12-8-py312-c9s-on-push | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-cuda-py312-c9s:{{revision}} | ||
| - name: dockerfile | ||
| value: base-images/cuda/12.8/c9s-python-3.12/Dockerfile.cuda | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - linux/arm64 | ||
| - name: path-context | ||
| value: . | ||
| - name: additional-tags | ||
| value: | ||
| - '{{target_branch}}-{{revision}}' | ||
| - v12.8 | ||
| pipelineRef: | ||
| name: multiarch-push-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-cuda-py312-c9s-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
52 changes: 52 additions & 0 deletions
52
.tekton/odh-base-image-cuda-12-8-py312-ubi9-pull-request.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # yamllint disable-file | ||
| # This pipeline is autogenerated by scripts/generate_pull_request_pipelineruns.py | ||
| --- | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: 'true' | ||
| pipelinesascode.tekton.dev/max-keep-runs: '3' | ||
| pipelinesascode.tekton.dev/on-comment: ^/kfbuild\s+(all|odh\-base\-image\-cuda\-py312\-ubi9|base\-images/cuda/12\.8/ubi9\-python\-3\.12) | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| event == "pull_request" && target_branch == "main" && ( "base-images/cuda/12.8/ubi9-python-3.12/**".pathChanged() || ".tekton/odh-base-image-cuda-12-8-py312-ubi9-pull-request.yaml".pathChanged() ) | ||
| && body.repository.full_name == "opendatahub-io/notebooks" | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-cuda-py312-ubi9 | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-cuda-12-8-py312-ubi9-on-pull-request | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| timeouts: | ||
| pipeline: 3h | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-cuda-py312-ubi9:on-pr-{{revision}} | ||
| - name: image-expires-after | ||
| value: 5d | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - linux/arm64 | ||
| - name: dockerfile | ||
| value: base-images/cuda/12.8/ubi9-python-3.12/Dockerfile.cuda | ||
| - name: path-context | ||
| value: . | ||
| pipelineRef: | ||
| name: multiarch-pull-request-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-cuda-py312-ubi9-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| #test2 | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: "false" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && ( "base-images/cuda/12.8/ubi9-python-3.12/**".pathChanged() || ".tekton/odh-base-image-cuda-12-8-py312-ubi9-push.yaml".pathChanged() ) | ||
| creationTimestamp: | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-cuda-py312-ubi9 | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-cuda-12-8-py312-ubi9-on-push | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-cuda-py312-ubi9:{{revision}} | ||
| - name: dockerfile | ||
| value: base-images/cuda/12.8/ubi9-python-3.12/Dockerfile.cuda | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - linux/arm64 | ||
| - name: path-context | ||
| value: . | ||
| - name: additional-tags | ||
| value: | ||
| - '{{target_branch}}-{{revision}}' | ||
| - v12.8 | ||
| pipelineRef: | ||
| name: multiarch-push-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-cuda-py312-ubi9-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
51 changes: 51 additions & 0 deletions
51
.tekton/odh-base-image-rocm-6-4-py312-c9s-pull-request.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # yamllint disable-file | ||
| # This pipeline is autogenerated by scripts/generate_pull_request_pipelineruns.py | ||
| --- | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: 'true' | ||
| pipelinesascode.tekton.dev/max-keep-runs: '3' | ||
| pipelinesascode.tekton.dev/on-comment: ^/kfbuild\s+(all|odh\-base\-image\-rocm\-py312\-c9s|base\-images/rocm/6\.4/c9s\-python\-3\.12) | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| event == "pull_request" && target_branch == "main" && ( "base-images/rocm/6.4/c9s-python-3.12/**".pathChanged() || ".tekton/odh-base-image-rocm-6-4-py312-c9s-pull-request.yaml".pathChanged() ) | ||
| && body.repository.full_name == "opendatahub-io/notebooks" | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-rocm-py312-c9s | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-rocm-6-4-py312-c9s-on-pull-request | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| timeouts: | ||
| pipeline: 3h | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-rocm-py312-c9s:on-pr-{{revision}} | ||
| - name: image-expires-after | ||
| value: 5d | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - name: dockerfile | ||
| value: base-images/rocm/6.4/c9s-python-3.12/Dockerfile.rocm | ||
| - name: path-context | ||
| value: . | ||
| pipelineRef: | ||
| name: multiarch-pull-request-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-rocm-py312-c9s-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: "false" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && ( "base-images/rocm/6.4/c9s-python-3.12/**".pathChanged() || ".tekton/odh-base-image-rocm-6-4-py312-c9s-push.yaml".pathChanged() ) | ||
| creationTimestamp: | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-rocm-py312-c9s | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-rocm-6-4-py312-c9s-on-push | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-rocm-py312-c9s:{{revision}} | ||
| - name: dockerfile | ||
| value: base-images/rocm/6.4/c9s-python-3.12/Dockerfile.rocm | ||
| - name: path-context | ||
| value: . | ||
| - name: additional-tags | ||
| value: | ||
| - '{{target_branch}}-{{revision}}' | ||
| - v6.4 | ||
| pipelineRef: | ||
| name: singlearch-push-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-rocm-py312-c9s-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
51 changes: 51 additions & 0 deletions
51
.tekton/odh-base-image-rocm-6-4-py312-ubi9-pull-request.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # yamllint disable-file | ||
| # This pipeline is autogenerated by scripts/generate_pull_request_pipelineruns.py | ||
| --- | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/pull_request_number: '{{pull_request_number}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: 'true' | ||
| pipelinesascode.tekton.dev/max-keep-runs: '3' | ||
| pipelinesascode.tekton.dev/on-comment: ^/kfbuild\s+(all|odh\-base\-image\-rocm\-py312\-ubi9|base\-images/rocm/6\.4/ubi9\-python\-3\.12) | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| event == "pull_request" && target_branch == "main" && ( "base-images/rocm/6.4/ubi9-python-3.12/**".pathChanged() || ".tekton/odh-base-image-rocm-6-4-py312-ubi9-pull-request.yaml".pathChanged() ) | ||
| && body.repository.full_name == "opendatahub-io/notebooks" | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-rocm-py312-ubi9 | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-rocm-6-4-py312-ubi9-on-pull-request | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| timeouts: | ||
| pipeline: 3h | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-rocm-py312-ubi9:on-pr-{{revision}} | ||
| - name: image-expires-after | ||
| value: 5d | ||
| - name: build-platforms | ||
| value: | ||
| - linux/x86_64 | ||
| - name: dockerfile | ||
| value: base-images/rocm/6.4/ubi9-python-3.12/Dockerfile.rocm | ||
| - name: path-context | ||
| value: . | ||
| pipelineRef: | ||
| name: multiarch-pull-request-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-rocm-py312-ubi9-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| apiVersion: tekton.dev/v1 | ||
| kind: PipelineRun | ||
| # test | ||
| metadata: | ||
| annotations: | ||
| build.appstudio.openshift.io/repo: https://github.com/opendatahub-io/notebooks?rev={{revision}} | ||
| build.appstudio.redhat.com/commit_sha: '{{revision}}' | ||
| build.appstudio.redhat.com/target_branch: '{{target_branch}}' | ||
| pipelinesascode.tekton.dev/cancel-in-progress: "false" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && ( "base-images/rocm/6.4/ubi9-python-3.12/**".pathChanged() || ".tekton/odh-base-image-rocm-6-4-py312-ubi9-push.yaml".pathChanged() ) | ||
| creationTimestamp: | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
| appstudio.openshift.io/component: odh-base-image-rocm-py312-ubi9 | ||
| pipelines.appstudio.openshift.io/type: build | ||
| name: odh-base-image-rocm-6-4-y312-ubi9-on-push | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| params: | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
| value: '{{revision}}' | ||
| - name: output-image | ||
| value: quay.io/opendatahub/odh-base-image-rocm-py312-ubi9:{{revision}} | ||
| - name: dockerfile | ||
| value: base-images/rocm/6.4/ubi9-python-3.12/Dockerfile.rocm | ||
| - name: path-context | ||
| value: . | ||
| - name: additional-tags | ||
| value: | ||
| - '{{target_branch}}-{{revision}}' | ||
| - v6.4 | ||
| pipelineRef: | ||
| name: singlearch-push-pipeline | ||
| taskRunTemplate: | ||
| serviceAccountName: build-pipeline-odh-base-image-rocm-py312-ubi9-poc | ||
| workspaces: | ||
| - name: git-auth | ||
| secret: | ||
| secretName: '{{ git_auth_secret }}' | ||
| status: {} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atheo89 I'm confused, is it correct to have this in rhds or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I’ve given up… we’re getting a lot of Tekton files coming from upstream into RHDS. The good thing is they don’t actually break anything (but they add some noise). Another plus is that they don’t make it into the release branch. Moulali mentioned he has an idea for how to prevent these files from coming downstream.