-
Notifications
You must be signed in to change notification settings - Fork 24
Rebase cpu.conf to pull from aipcc #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/build-konflux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This PR updates the BASE_IMAGE in several cpu.conf files to use a new image from quay.io/aipcc/base-images/cpu. The changes are consistent and straightforward.
🔍 General Feedback
- The change is applied consistently across all relevant files.
- I've added a comment regarding the pinned version of the base image, which applies to all the files changed in this PR. Consider if a more generic tag could be used to simplify future maintenance.
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
|
/build-konflux |
jiridanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeserver image does not work https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/rhoai-tenant/applications/automation/pipelineruns/odh-workbench-codeserver-datascience-cpu-py312-on-pull-reqwpvzr/logs?task=build-images
Debug: '/opt/app-root/src/.vscode/launch.json' file created.
/opt/app-root/etc/generate_container_user: line 6: envsubst: command not found
ERROR: ld.so: object 'libnss_wrapper.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
probe_once: False [Errno 111] Connection refused
probe_once: False [Errno 111] Connection refused
probe_once: False [Errno 111] Connection refused
FAIL
======================================================================
FAIL: test_codeserver_startup (__main__.TestStartup.test_codeserver_startup)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/test/test_startup.py", line 74, in test_codeserver_startup
self.assertEqual(ret, 0, "Probe check should return 0")
AssertionError: 1 != 0 : Probe check should return 0
----------------------------------------------------------------------
Ran 1 test in 20.016s
FAILED (failures=1)
odh-workbench-coe13e3287879be27ba132b8a86267e8e0-build-images-0.log
|
/build-konflux |
22150af to
9f9ae5e
Compare
|
/build-konflux |
|
/build-konflux |
|
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ysok The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Closing this in favor of #1683 |
This PR rebase cpu.conf to pull from aipcc cpu base
This undoes
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: