Skip to content

Conversation

@atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 14, 2025

This PR rebase cpu.conf to pull from aipcc cpu base

This undoes

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89
Copy link
Member Author

atheo89 commented Oct 14, 2025

/build-konflux

@atheo89 atheo89 requested a review from jiridanek October 14, 2025 15:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the BASE_IMAGE in several cpu.conf files to use a new image from quay.io/aipcc/base-images/cpu. The changes are consistent and straightforward.

🔍 General Feedback

  • The change is applied consistently across all relevant files.
  • I've added a comment regarding the pinned version of the base image, which applies to all the files changed in this PR. Consider if a more generic tag could be used to simplify future maintenance.

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@atheo89
Copy link
Member Author

atheo89 commented Oct 15, 2025

/build-konflux

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeserver image does not work https://konflux-ui.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/ns/rhoai-tenant/applications/automation/pipelineruns/odh-workbench-codeserver-datascience-cpu-py312-on-pull-reqwpvzr/logs?task=build-images

Debug: '/opt/app-root/src/.vscode/launch.json' file created.
/opt/app-root/etc/generate_container_user: line 6: envsubst: command not found
ERROR: ld.so: object 'libnss_wrapper.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
probe_once: False [Errno 111] Connection refused
probe_once: False [Errno 111] Connection refused
probe_once: False [Errno 111] Connection refused
FAIL
======================================================================
FAIL: test_codeserver_startup (__main__.TestStartup.test_codeserver_startup)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/test/test_startup.py", line 74, in test_codeserver_startup
    self.assertEqual(ret, 0, "Probe check should return 0")
AssertionError: 1 != 0 : Probe check should return 0
----------------------------------------------------------------------
Ran 1 test in 20.016s
FAILED (failures=1)

odh-workbench-coe13e3287879be27ba132b8a86267e8e0-build-images-0.log

@atheo89
Copy link
Member Author

atheo89 commented Oct 21, 2025

/build-konflux

@atheo89 atheo89 force-pushed the rebase-downstream-cpu branch from 22150af to 9f9ae5e Compare October 21, 2025 13:27
@atheo89
Copy link
Member Author

atheo89 commented Oct 21, 2025

/build-konflux

@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 24, 2025
@jiridanek
Copy link
Member

/build-konflux

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 58ba8fd link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ysok
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Nov 11, 2025

Closing this in favor of #1683
as the rebase messed up

@atheo89 atheo89 closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm review-requested tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants