Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 15, 2025

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz November 15, 2025 12:42
@jiridanek jiridanek force-pushed the jd_templatizing_rhds branch 2 times, most recently from ad184ff to b4eeada Compare November 15, 2025 13:04
@jiridanek
Copy link
Member Author

/build-konflux

@jiridanek jiridanek force-pushed the jd_templatizing_rhds branch from b4eeada to 6cc28de Compare November 15, 2025 15:14
@jiridanek
Copy link
Member Author

/build-konflux

@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2025

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 6cc28de link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit a8a75f4 into red-hat-data-services:main Nov 15, 2025
37 of 73 checks passed
@jiridanek jiridanek deleted the jd_templatizing_rhds branch November 15, 2025 16:12
jiridanek added a commit that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants