Remove sha1 pre-hashing from password handling#6460
Merged
Conversation
Previously, passwords were sha1-hashed before being passed to password_hash/password_verify (a leftover from client-side hashing in REDAXO 5.x). This removes the sha1 layer entirely: - Remove `$isPreHashed` parameter from `setLogin`, `passwordHash`, `passwordVerify` - Remove client-side sha1 hashing from login form and `sha1.js` asset - Add legacy fallback in `BackendLogin::passwordVerify` for old sha1-wrapped password hashes, with automatic rehashing on next login - Use `static::` instead of `self::` for `passwordVerify` in `Login::checkLogin` to enable late static binding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gharlan
force-pushed
the
remove-password-pre-hashing
branch
from
451b756 to
8c13d9c
Compare
gharlan
force-pushed
the
remove-password-pre-hashing
branch
from
3e705ae to
fc7c918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, passwords were sha1-hashed before being passed to
password_hash/password_verify (a leftover from client-side hashing
in REDAXO 5.x). This removes the sha1 layer entirely:
$isPreHashedparameter fromsetLogin,passwordHash,passwordVerifysha1.jsassetBackendLogin::passwordVerifyfor oldsha1-wrapped password hashes, with automatic rehashing on next login
static::instead ofself::forpasswordVerifyinLogin::checkLoginto enable late static bindingcloses #2127