Implement static package versioning#113
Conversation
|
Yeah in practice its the same, it comes down to what files you expect to see changed during a PR review. Technically, this is backwards incompatible as you're removing Someone might be doing That will |
|
Good catch! I've added that variable back in for backwards compatibility. I know it's not ideal to have it documented in two places (i.e why you had the other process 😉) though I think this is worth the short term benefit of making the package version work when installing from GitHub. And in the long term, we might be able to come up with a different strategy that meets both needs. |
|
Alternatively, if you don't want to double document this, we could try refactoring the Or do you think that still wouldn't solve our problem? |
Tested this locally and it sucessfully recognized the version. 🙇♂️ many thanks to `vulture`
|
I tested installing from this branch and successfully got version 1.0.2 🎉 Now we can have the version in one place and have it be recognized when installing from GitHub |
Fixes #87
I saw that you had the versioning in it's own file before, but I think that wasn't getting picked up when doing GitHub installs.
I thought this would be the most straightforward solution since:
version.pyseems to be else where in the package such as the__init__.pyand also thesetup.py__init__.pyAND in thesetup.py, though I could be missing something.setup.py