Skip to content

Added new forceAutoNumber parameter to import_records method.#86

Merged
sburns merged 1 commit intoredcap-tools:masterfrom
GeneDx:force-auto-number
Oct 20, 2018
Merged

Added new forceAutoNumber parameter to import_records method.#86
sburns merged 1 commit intoredcap-tools:masterfrom
GeneDx:force-auto-number

Conversation

@CarlosBorroto
Copy link
Copy Markdown
Contributor

We would like to use the forceAutoNumber parameter of the import_records API endpoint. This allows auto-numbering project feature to ignore the record_id provided by the user and instead use auto-incremented record ids as per project setting.

@CarlosBorroto CarlosBorroto changed the title Added new forceAutoNumber parameter to importRecords method. Added new forceAutoNumber parameter to import_records method. Sep 26, 2018
@sburns
Copy link
Copy Markdown
Collaborator

sburns commented Sep 26, 2018

Woah I'm glad they added this to the API! Our test suite is in shambles now, have you run this locally to verify it works?

@CarlosBorroto
Copy link
Copy Markdown
Contributor Author

Yes, I ran multiple local tests and I'm also using the fork with this change in a script we are running in production. So far so good.

I wanted to write a test, but I saw the issue with the failing REDCap instance used in tests.

@sburns
Copy link
Copy Markdown
Collaborator

sburns commented Sep 28, 2018

Do you have access to an instance we could use for our tests?

@sburns
Copy link
Copy Markdown
Collaborator

sburns commented Oct 12, 2018

Hi @CarlosBorroto, a separate PR implemented tests that don't need a redcap instance, would you mind back-merging master? We should have green tests then.

@CarlosBorroto
Copy link
Copy Markdown
Contributor Author

@sburns will do. Sorry I missed you previous question. I don't have access to an instance. I'm working with a collaborator which is using redcap.

@firaswehbe
Copy link
Copy Markdown

Hey guys. I run a training instance of REDCap that is public and has table authentication, please email me firas.wehbe [chez] northwestern edu, and I will be happy to provision you as user if still needed for these tests or others needed in future PRs

@sburns
Copy link
Copy Markdown
Collaborator

sburns commented Oct 15, 2018

@firaswehbe #85 moved our tests to not requiring a running instance (and making http requests to a running service in a testsuite is icky anyways) so while I very much appreciate the offer, I don't think we need it now.

@CarlosBorroto
Copy link
Copy Markdown
Contributor Author

@sburns I finally got around to update this PR. Tests are now passing. Nice job removing the dependency on a running instance.

@sburns sburns merged commit edc19a5 into redcap-tools:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants