Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Comment/Message Preview Support#20

Closed
smoak wants to merge 2 commits intoreddit-archive:masterfrom
smoak:comment_preview
Closed

Comment/Message Preview Support#20
smoak wants to merge 2 commits intoreddit-archive:masterfrom
smoak:comment_preview

Conversation

@smoak
Copy link
Copy Markdown

@smoak smoak commented Nov 4, 2010

Uses api controller for comment/message preview support.

@spladug
Copy link
Copy Markdown
Contributor

spladug commented Apr 20, 2011

This should be done entirely client side, not via a roundtrip to the server.

@spladug spladug closed this Apr 20, 2011
@smoak
Copy link
Copy Markdown
Author

smoak commented Apr 21, 2011

I thought reddit has a customized version of markdown. Earlier before this patch I submitted a patch for comment preview support using showdown (markdown in JavaScript). I asked on IRC about it and the general consensus was that since reddit has a customized version of markdown it wouldn't be so great as a client side script.

@spladug
Copy link
Copy Markdown
Contributor

spladug commented Apr 21, 2011

We use discount as our
Markdown implementation. We do turn off several features (such as images)
but that should be the only customization needed. I'm not sure why your
previous request was rejected. I definitely feel that roundtripping for
markdown is not the right way to do it. We will be getting a frontend
developer very soon and I'll have him take a look. Thanks and sorry for the
trouble :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants