Skip to content

Cancel thumb view touches with ACTION_CANCEL #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DSteve595 merged 1 commit into from
Sep 20, 2019
Merged

Cancel thumb view touches with ACTION_CANCEL #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion indicator-fast-scroll/src/main/java/com/reddit/indicatorfastscroll/FastScrollerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class FastScrollerView @JvmOverloads constructor(
override fun onTouchEvent(event: MotionEvent): Boolean {
fun View.containsY(y: Int) = y in (top until bottom)

if (event.action == MotionEvent.ACTION_UP) {
if (event.action in MOTIONEVENT_STOP_ACTIONS) {
isPressed = false
lastSelectedPosition = null
onItemIndicatorTouched?.invoke(false)
Expand Down Expand Up @@ -347,6 +347,11 @@ class FastScrollerView @JvmOverloads constructor(

companion object {

private val MOTIONEVENT_STOP_ACTIONS = intArrayOf(
MotionEvent.ACTION_UP,
MotionEvent.ACTION_CANCEL
)

private fun FastScrollerView.createAdapterDataObserver(): RecyclerView.AdapterDataObserver {
return object : RecyclerView.AdapterDataObserver() {
override fun onChanged() {
Expand Down