Fix connect leak from clientpool #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
konradreiche and
kylelemons
and removed request for
a team
kylelemons
approved these changes
Feb 2, 2022
konradreiche
approved these changes
Feb 2, 2022
Contributor
Author
|
Alternatively we can also do it here, @kylelemons & @konradreiche do you have a strong preference either way? |
alienth
approved these changes
Feb 2, 2022
fishy
force-pushed
the
fix-connect-leak
branch
from
4e5939a to
afe3cfa
Compare
Contributor
Author
|
💇 moved the fix to clientpool so it's more foolproof (for example, in the future we no longer wrap clients with ttlClient). |
fishy
changed the title
konradreiche
approved these changes
Feb 2, 2022
kylelemons
approved these changes
Feb 3, 2022
Contributor
Author
|
💇 added the fix to another place, which is the actual one triggered by envoy. |
konradreiche
approved these changes
Feb 3, 2022
It's also fixed upstream in thrift and will be part of thrift 0.16.0, but the double fix is harmless and will help us when it's used on older thrift versions.
fishy
force-pushed
the
fix-connect-leak
branch
from
a437085 to
9cad58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be triggered by envoy closing the connections differently
from thrift servers.