always update thrift header write list in headerbp client middleware#685
Merged
pacejackson merged 2 commits intoreddit:masterfrom Feb 20, 2025
Merged
always update thrift header write list in headerbp client middleware#685pacejackson merged 2 commits intoreddit:masterfrom
pacejackson merged 2 commits intoreddit:masterfrom
Conversation
… not just when we add new headers
pacejackson
requested review from
fishy,
konradreiche and
kylelemons
and removed request for
a team
fishy
approved these changes
Feb 19, 2025
konradreiche
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This is really just to make the code cleaner since it technically works because
thrift.GetWriteHeaderListreturns the underlying list, not a copy, andslices.Deletedeletes from the source slice. I think the code is a lot clearer and less likely to have a bug later if we always set the outgoing header list.I verified this by adding a test case. The test passes without my changes, but it fails if I copy
outgoingbefore deleting the headers from it.