Rename baseplate_log_latency_seconds to baseplate_log_write_duration_seconds#689
Merged
reptile-deer-66 merged 3 commits intoreddit:masterfrom Feb 26, 2025
Merged
Conversation
…on_seconds The new name makes it clear that this captures the duration of local logging calls as opposed to end-to-end logging latency to the centralized collector.
reptile-deer-66
requested review from
konradreiche and
kylelemons
and removed request for
a team
fishy
approved these changes
Feb 25, 2025
reptile-deer-66
changed the title
konradreiche
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new name makes it clear that this captures the duration of local logging calls as opposed to end-to-end logging latency to a centralized collector.