Conversation
added 13 commits
April 22, 2025 12:32
cytommi
commented
Apr 23, 2025
cytommi
commented
Apr 23, 2025
Collaborator
Author
There was a problem hiding this comment.
Sneaking in product images with correct sizes in this PR
diego-codes
requested changes
Apr 23, 2025
Collaborator
diego-codes
left a comment
diego-codes
left a comment
There was a problem hiding this comment.
A lot of my comments revolve around duplicative and unnecessary styles. Hopefully they'll help reduce number of classes used.
Collaborator
|
I forgot to mention:
|
cytommi
commented
Apr 24, 2025
added 2 commits
April 24, 2025 15:09
diego-codes
requested changes
Apr 24, 2025
packages/classic-webview/src/components/UnlockHardcoreModal.tsx
Outdated
Show resolved
Hide resolved
packages/classic-webview/src/components/UnlockHardcoreModal.tsx
Outdated
Show resolved
Hide resolved
packages/classic-webview/src/components/UnlockHardcoreModal.tsx
Outdated
Show resolved
Hide resolved
| const { setModal } = useModal(); | ||
|
|
||
| return ( | ||
| <div className="bg-night flex min-h-screen items-center justify-center p-4 text-center font-sans"> |
Collaborator
There was a problem hiding this comment.
request: There is already a Modal component in webview-common please use it here instead of creating a new type of modal.
added 3 commits
April 24, 2025 16:28
diego-codes
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "unlock hardcore mode" page. Buttons currently don't do anything.
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks