Skip to content

add back in 'ValidateToken' method that was accidentally removed#30

Merged
pacejackson merged 2 commits intoreddit:developfrom
pacejackson:fix-breaking-change
Jul 10, 2025
Merged

add back in 'ValidateToken' method that was accidentally removed#30
pacejackson merged 2 commits intoreddit:developfrom
pacejackson:fix-breaking-change

Conversation

@pacejackson
Copy link
Contributor

@pacejackson pacejackson commented Jul 10, 2025

💸 TL;DR

This was accidentally removed from the public API, adding it back in.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@pacejackson pacejackson requested review from fishy and nanassito July 10, 2025 19:43

// ValidateToken parses and validates a jwt token, and return the decoded
// AuthenticationToken.
func (i *Impl) ValidateToken(token string) (*AuthenticationToken, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔕 hmm I can't remember what this used to be, but it would be great if we can pass in ctx in the function signature.

but it's fine if we want to keep backward compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, this is the exact signature it used to have.

@pacejackson pacejackson merged commit 6e02af4 into reddit:develop Jul 10, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants