Skip to content

Conversation

@vibe13
Copy link
Member

@vibe13 vibe13 commented Sep 5, 2024

No description provided.

@openshift-ci openshift-ci bot requested a review from rnc September 5, 2024 08:24
@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2024
@vibe13
Copy link
Member Author

vibe13 commented Sep 5, 2024

/retest

Copy link
Collaborator

@rnc rnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, I think we're missing a change to https://github.com/redhat-appstudio/jvm-build-service-builder-images/blob/main/image-config.yaml#L13 and to the other references to 1.10.13 (in this repo) so I'm sorry but I think this needs further work.

@openshift-ci openshift-ci bot removed the lgtm label Sep 5, 2024
@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2024
@rnc
Copy link
Collaborator

rnc commented Sep 6, 2024

/retest

@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.52%. Comparing base (72e9c39) to head (5425e18).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2076   +/-   ##
=========================================
  Coverage     39.52%   39.52%           
  Complexity      812      812           
=========================================
  Files           301      301           
  Lines         14145    14145           
  Branches       1467     1467           
=========================================
  Hits           5591     5591           
  Misses         7906     7906           
  Partials        648      648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vibe13 vibe13 force-pushed the update-builder-images branch from 8f6a0a0 to 5425e18 Compare September 10, 2024 07:55
@openshift-ci openshift-ci bot removed the lgtm label Sep 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

New changes are detected. LGTM label has been removed.

@vibe13 vibe13 merged commit 4028afa into redhat-appstudio:main Sep 10, 2024
@vibe13 vibe13 deleted the update-builder-images branch September 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants